http server use both settimeout and makefile
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Undecided
|
Vincent Ladeuil |
Bug Description
http://
...
A consequence of this is that file objects returned by the makefile() method must only be used when the socket is in blocking mode; in timeout or non-blocking mode file operations that cannot be completed immediately will fail.
...
So we must not use timeouts in HttpServer.
This has caused problems on Mac OS X for a long time and we tried to address them by retrying on socket.error.EAGAIN (Resource temporarily unavailable).
Lately, this has also make a test fail for the webdav plugin (namely test_readv_
Now, it seems that originally this timeout was introduced to avoid hanging the test suite.
I think this is a different problem that should be addressed by the test suite itself in a more general way.
Changed in bzr: | |
status: | New → Confirmed |
Changed in bzr: | |
assignee: | nobody → v-ladeuil |
status: | Confirmed → In Progress |
Changed in bzr: | |
status: | In Progress → Fix Committed |
Changed in bzr: | |
milestone: | none → 0.92 |
status: | Fix Committed → Fix Released |