‘Wrap when cycling objects in z-order’ works when unchecked

[Sylvain Chiron]

When the setting ‘Wrap when cycling objects in z-order’ is unchecked (Preferences > Behavior > Selection), the wrapping still works when going from bottom to top (but not with the other direction).

I also wonder whether the selection of the first object is buggy… I would advise to select the topmost object when going top to bottom, and the deepest object if starting in the other direction (no matter the state of the setting).

[jazzynico (jazzynico)]

Reproduced on Windows XP (32-bit), Inkscape trunk rev. 14968.
Not reproduced with 0.91.

[jazzynico (jazzynico)]

To narrow down a bit, it can be reproduced with rev. 14538, but not with rev. 14506.

[jazzynico (jazzynico)]

Regression introduced rev. 14520 (http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14520).
Patch in progress.

[jazzynico (jazzynico)]

Hmm, the patch isn't as obvious as I expected. I'm going to ask the committer.

[Mc (mc...)]

Assigning to myself, I'll try to take a look next week

[Sylvain Chiron (frigory)]

In 0.91, the preference works well, but the first selection when selecting from bottom is still not what I would expect.

[Mc (mc...)]

attached a patch for testing

[jazzynico (jazzynico)]

Patch from comment #7 tested successfully on Xubuntu 16.04, Inkscape trunk rev. 14987.

But there's a regression (compared to 0.91) with the way the selected object is taken into account in the list (as explained by Sylvain comment #6).

[Sylvain Chiron (frigory)]

Comment #6 doesn't speak of a regression… I said the first selected object was not the right one when selecting from bottom, and this is also the case in 0.91 from my tests.

[Mc (mc...)]

committed to r14988