apiserver/provisioner: tests do not pass with go 1.7 beta 1

[Dave Cheney]

http://paste.ubuntu.com/17055649/

[Cheryl Jennings (cherylj)]

All the errors are the same as:

provisioninginfo_test.go:111:
    c.Assert(result, jc.DeepEquals, expected)
... obtained params.ProvisioningInfoResults = params.ProvisioningInfoResults{Results:[]params.ProvisioningInfoResult{params.ProvisioningInfoResult{Error:<nil>, Result:(*params.ProvisioningInfo)(0xc420b456c0)}, params.ProvisioningInfoResult{Error:<nil>, Result:(*params.ProvisioningInfo)(0xc420bac680)}}}
... expected params.ProvisioningInfoResults = params.ProvisioningInfoResults{Results:[]params.ProvisioningInfoResult{params.ProvisioningInfoResult{Error:<nil>, Result:(*params.ProvisioningInfo)(0xc420bac750)}, params.ProvisioningInfoResult{Error:<nil>, Result:(*params.ProvisioningInfo)(0xc420bac820)}}}
... mismatch at (*.Results[0].Result).ImageMetadata: length mismatch, 48 vs 0; obtained []params.CloudImageMetadata{params.CloudImageMetadata{ImageId:"ami-0eff953e", Stream:"daily", Region:"us-west-2", Version:"12.10", Series:"quantal", Arch:"i386", VirtType:"pv", RootStorageType:"ebs", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-0f02f878", Stream:"daily", Region:"eu-west-1", Version:"12.10", Series:"quantal", Arch:"amd64", VirtType:"hvm", RootStorageType:"ebs", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-1102f866", Stream:"daily", Region:"eu-west-1", Version:"12.10", Series:"quantal", Arch:"amd64", VirtType:"pv", RootStorageType:"ebs", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-1588102f", Stream:"daily", Region:"ap-southeast-2", Version:"12.10", Series:"quantal", Arch:"amd64", VirtType:"hvm", RootStorageType:"instance", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-17fa8216", Stream:"daily", Region:"ap-northeast-1", Version:"12.10", Series:"quantal", Arch:"i386", VirtType:"pv", RootStorageType:"ebs", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-2302f854", Stream:"daily", Region:"eu-west-1", Version:"12.10", Series:"quantal", Arch:"i386", VirtType:"pv", RootStorageType:"ebs", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-258cf424", Stream:"daily", Region:"ap-northeast-1", Version:"12.10", Series:"quantal", Arch:"i386", VirtType:"pv", RootStorageType:"instance", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-304f1c62", Stream:"daily", Region:"ap-southeast-1", Version:"12.10", Series:"quantal", Arch:"i386", VirtType:"pv", RootStorageType:"instance", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImageMetadata{ImageId:"ami-30d0b800", Stream:"daily", Region:"us-west-2", Version:"12.10", Series:"quantal", Arch:"amd64", VirtType:"hvm", RootStorageType:"instance", RootStorageSize:(*uint64)(nil), Source:"default ubuntu cloud images", Priority:10}, params.CloudImag...

[John A Meinel (jameinel)]

So we introduced internal code to prevent us from contacting remote sites during the test suite. My guess is go changed something and the bit we were overriding is not working in 1.7

[Anastasia (anastasia-macmood)]

This must have been fixed a while ago as we are now using go 1.7 and tests pass. Here is an output from go1.7.4 linux/amd64 https://pastebin.canonical.com/179071/

Since I cannot target this to previous milestones, I am adding it to currently closest available milestone of 2.1.0.