compiler failure in FindPanoDialog.cpp, "void value not ignored as it ought to be"

[Matthias Andree]

[ 85%] Building CXX object src/hugin1/ptbatcher/CMakeFiles/PTBatcherGUI.dir/FindPanoDialog.cpp.o
cd /home/mandree/VCS-other/hugin/src/hugin/hugin.build/src/hugin1/ptbatcher && /usr/bin/c++ -DGLEW_STATIC -DHUGIN_HSI -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -pthread -O2 -g -DNDEBUG -I/home/mandree/VCS-other/hugin/src/hugin/hugin.build/src -I/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/hugin_base -I/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/celeste -I/home/mandree/VCS-other/hugin/src/hugin/hugin.build/src/celeste -I/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src -I/usr/include/x86_64-linux-gnu -I/usr/include/OpenEXR -I/usr/local/include -I/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/foreign -I/usr/include/python2.7 -I/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/hugin1 -isystem /usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-release-2.8 -isystem /usr/include/wx-2.8 -fopenmp -pthread -std=gnu++11 -o CMakeFiles/PTBatcherGUI.dir/FindPanoDialog.cpp.o -c /home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/hugin1/ptbatcher/FindPanoDialog.cpp
/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/hugin1/ptbatcher/FindPanoDialog.cpp: In member function 'void FindPanoDialog::OnSplitPanos(wxCommandEvent&)':
/home/mandree/VCS-other/hugin/src/hugin/hugin.hg/src/hugin1/ptbatcher/FindPanoDialog.cpp:444:126: error: void value not ignored as it ought to be
                     int newItem = m_list_pano->Insert(m_panos[selectedPano + 1]->GetItemString(m_start_dir), selectedPano + 1);
                                                                                                                              ^
make[2]: *** [src/hugin1/ptbatcher/CMakeFiles/PTBatcherGUI.dir/FindPanoDialog.cpp.o] Error 1

(the marker is at the final closing parenthesis)

This is with

#define VERSION_MAJOR 2016
#define VERSION_MINOR 3
#define VERSION_PATCH 0
#define HUGIN_WC_REVISION 7cf531fff7d2
#define HUGIN_API_VERSION "2016.3"

[Matthias Andree (matthias-andree)]

This is on Ubuntu 14.04.X LTS 64-bit with
g++-4.9.real (Ubuntu 4.9.3-8ubuntu2~14.04) 4.9.3

[Matthias Andree (matthias-andree)]

Failure inducing change (bug added with new feature):

changeset: 7369:429e075cbf04
user: tmodes
date: Thu May 05 19:14:34 2016 +0200
files: src/hugin1/ptbatcher/FindPanoDialog.cpp src/hugin1/ptbatcher/FindPanoDialog.h
description:
Added context menu to find pano dialog
* user can remove images from found panos
* split a pano into 2 subpanos

[Stefan Peter (s-peter-deactivatedaccount)]

Hi Matthias

There are working trusty builds for 2016.3 (currently hg7426) at https://launchpad.net/~hugin/+archive/ubuntu/nightly. Are you using the same dependencies like these builds? hg7369 was quite some time ago, the nightly builds have been active then and I don't remember this breakage.

With kind regards

Stefan Peter

[Matthias Andree (matthias-andree)]

I figured that I was doing out-of-source builds, as recommended, but that there were stale CMake cache files in the source tree. A quick "hg status | xargs rm -f" got rid of them, and a quick "hg update -C ." just to be on the safe side, and re-cmake'ing in the build directory, sorted things for me.

So "pilot error", closing this bug as invalid, sorry for the noise, and thanks for the prompt reply.