fuel-library build should fail if module pull fails

[Alex Schultz]

When the build process for fuel-library is running, we pull modules from a remote source. Unfortunately when we get timeouts or other connection failures, the build process of fuel-library does not stop so we end up with odd failures during deployment. We should fail if not all the modules are pulled down during the fuel-library build phase.

https://ci.fuel-infra.org/job/10.0-community.all/236/consoleFull

Steps to reproduce:
attempt to build fuel-library package, have some of the modules fail to download.

Expected results:
Build should fail if not all modules are downloaded.

Actual results:
odd failures during deployment

Reproducibility:
occasionally

Workaround:
Rebuild fuel-library

Impact:
Random CI/BVT failures

[Alex Schultz (alex-schultz)]

https://review.openstack.org/325416

[Andrey Sledzinskiy (asledzinskiy)]

Raise to critical because it fails 10.0 bvt

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325416
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f6ea0881c9cc628a311c98070198f441741ee731
Submitter: Jenkins
Branch: master

commit f6ea0881c9cc628a311c98070198f441741ee731
Author: Alex Schultz <email address hidden>
Date: Fri Jun 3 10:58:49 2016 -0600

    Error if librarian-puppet fails

    This change checks the return code status of librarian puppet and
    stops the script execution if there is anerror. Without this change
    if librarian-puppet encounters an error, the script would continue
    and not all the modules may be available. This is problematic for
    the build systems that are using this script to pull down the modules.

    Change-Id: Ic7277deb957072abcae9a8639196938b24288cfa
    Closes-Bug: #1588895