qml/Ubuntu/Components/1.3/AdaptivePageLayout.qml:828: TypeError: Cannot read property 'header' of null
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Tim Peeters |
Bug Description
Using the AdaptivePageLayout in something other than a MainView causes it to look for a header that isn't there even if all Page's use their own header.
Note: Functionally this works fine.
Item {
AdaptivePag
header: PageHeader {
}
}
}
}
qml/Ubuntu/
qml/Ubuntu/
qml/Ubuntu/
This occurs with a hypothetical MainView alternative (bug 1587431) as well as a custom root component tailored to the app.
Related branches
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 58 lines (+10/-8)2 files modifiedsrc/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+7/-6)
tests/unit/visual/tst_adaptivepagelayout.qml (+3/-2)
- PS Jenkins bot: Pending (continuous-integration) requested
- Ubuntu SDK team: Pending requested
-
Diff: 868 lines (+302/-89)34 files modifiedcomponents.api (+6/-0)
export_qml_dir.sh (+2/-0)
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+11/-6)
src/Ubuntu/Components/1.3/PageHeader.qml (+2/-1)
src/Ubuntu/Components/1.3/TextArea.qml (+3/-4)
src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml (+1/-0)
src/Ubuntu/Components/Styles/1.3/SectionsStyle.qml (+50/-0)
src/Ubuntu/Components/Styles/Styles.pro (+1/-3)
src/Ubuntu/Components/Styles/qmldir (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/1.2/PageHeadButton.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadButton.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+10/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml (+16/-30)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+6/-0)
src/Ubuntu/Components/Themes/ThemesModule.pro (+0/-3)
src/Ubuntu/Components/plugin/ucabstractbutton.cpp (+0/-3)
src/Ubuntu/Components/plugin/ucperformancemonitor.cpp (+24/-6)
tests/unit/add_qmlmakecheck.pri (+1/-1)
tests/unit/add_qmlmakecheck_x11.pri (+1/-1)
tests/unit/i18n/LocalizedApp/LocalizedApp.pro (+0/-1)
tests/unit/i18n/RelativeTime/RelativeTime.pro (+0/-1)
tests/unit/mainview/mainview.pro (+0/-2)
tests/unit/page/page.pro (+0/-2)
tests/unit/performance/TextArea13Grid.qml (+33/-0)
tests/unit/performance/tst_performance.cpp (+1/-0)
tests/unit/runtest.sh (+20/-15)
tests/unit/visual/gallery.qml (+78/-0)
tests/unit/visual/gallery.sh (+6/-0)
tests/unit/visual/tst_adaptivepagelayout.qml (+3/-2)
tests/unit/visual/tst_pageheader.qml (+2/-1)
tests/unit/visual/tst_picker13.qml (+1/-0)
tests/unit/visual/tst_popups_dialog13.qml (+13/-0)
tests/xvfb.sh (+7/-4)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
milestone: | none → 13 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2060+ 16.10.20160814
--------------- 16.10.20160814) yakkety; urgency=medium
ubuntu-ui-toolkit (1.3.2060+
[ Zoltan Balogh ] estCase tests.
* Fix OptionSelectorT
* Fix more OptionSelector autopilot tests
[ Timo Jyrinki ]
* Disable documentation building for GLES builds. Fixes LP: #1606222.
* Replace abs with qFabs due to GCC6 breakage. Fixes LP: #1610943.
* Limit s390x dependencies more due to upstart/s390x problems and removed
packages in archives. Fixes LP: #1610951
[ Andrea Bernabei ]
* ListItemLayout doc: add elide mode change example and add section about
labels default properties values. Fixes LP: #1603450.
* ListItemLayout doc: add explicit note about the need to bind ListItem's
height to layout's height.
* More Scrollbar optimizations: 20% faster creation time. Fixes LP: #1606451
* Scrollbar: fix wrong thumb color on tap/mouse release and increase coverage
of hover states unit tests. Fixes LP: #1608897
[ Zsombor Egri ]
* Fix null pointer property initializer used with 1.3 PageWrapper.
Fixes LP: #1604780.
* Fix BottomEdge content URL preloading. Fixes LP: #1604509.
[Albert Astals Cid ] :resolveResourc e: Prefer image path if it exists. This saves :resolveResourc e call down
* UCUnits:
searching the disk for @gu images, which is a big speedup. According to
callgrind loading 100 images from a folder that contains 380 images goes
from around 3 million instructions per UCUnits:
to around 10 thousand. This optimization is ok since it is not correct to
ship both image.png and image@20.png. You either have to ship gu-enabled
files or not, but mixing them is not allowed. Searched for cases in which
that may be happening in my phone and found none. Fixes LP: #1604029.
[ Tim Peeters ] Popover Autopilot CPO tests.
* Configure colors of the buttons in the ActionBar and PageHeader through
their Styles. Fixes LP: #1597774.
* Fix assigning of constant values to a grouped property in StyleHints.
Fixes LP: #1602836.
* Fix list view keyboard navigation for RightToLeft and BottomToTop
directions. Fixes LP: #1605634
* Use external QML files instead of embedded QML strings for autopilot tests.
Fixes LP: #1578319
* Fix failing autopilot header tests.
* Fix ActionSelection
[Christian Dywan ]
* Include indexes in "offline" docs and filter out link errors.
Fixes LP: #1603937.
* Increase focus ring thickness from 1dp to 2dp. Fixes LP: #1602690.
* Add a snippet about tests to the toplevel README
* Enter/Return to trigger, Space to expand ComboButton. Fixes LP: #1523817.
* Initialize engine variable before using it in the _engine case.
* Use Qt.rgba instead of #0000 checking ListItem default color.
Fixes LP: #1560004
* Don't use a different .desktop file in the gallery tests.
Fixes LP: #1578319
* Update scaling docs, set QT_SCALE_FACTOR and unset GRID_UNIT_PX.
Fixes LP: #1610208
[ Florian Boucault ]
* Sections: load Icons asynchronously.
-- Zoltán Balogh <email address hidden> Sun, 14 Aug 2016 09:06:46 +0000