liberasurecode

erasurecode.c fails to compile on OS X with Clang

Bug #1587954 reported by Eric Lambert
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
liberasurecode
Fix Released
Undecided
Eric Lambert

Bug Description

On OS X with clang (Apple LLVM version 7.0.2 (clang-700.1.81)) attempt to build fails with the following compilation error:

CC=clang ./configure && make
....
erasurecode.c:1090:17: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
    if (md->idx < 0 || (md->idx > (k + m)))

Eric Lambert (elambert)
Changed in liberasurecode:
assignee: nobody → Eric Lambert (elambert)
status: New → Confirmed
Eric Lambert (elambert)
Changed in liberasurecode:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to liberasurecode (master)

Fix proposed to branch: master
Review: https://review.openstack.org/324083

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to liberasurecode (master)

Reviewed: https://review.openstack.org/324083
Committed: https://git.openstack.org/cgit/openstack/liberasurecode/commit/?id=f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5
Submitter: Jenkins
Branch: master

commit f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5
Author: Eric Lambert <email address hidden>
Date: Wed Jun 1 09:21:25 2016 -0700

    Fix clang compile time error

    Removed unnecessary check that metadata index was not negative.
    Check is unneeded because type is unsigned and as such can not be
    negative.

    Change-Id: I72eddf78b25b3ff9bedbd596095f04be855c3817
    Closes-Bug: 1587954

Changed in liberasurecode:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.