[SR-IOV] Unable to migrate instance with macvtup port

[Sergii]

Detailed bug description:
When I try to migrate instance, sometimes it tries to migrate on node without SR-IOV. We have 3 compute nodes, 2 of them with SR-IOV (node-2 and node-7) and another one (node-8) without.

Steps to reproduce:

Deploy env with 1 controller, 2 computes with SR-IOV feature and 1 compute without SR-IOV.

1. neutron net-create net01
2. neutron subnet-create --name net01__subnet net01 10.1.1.0/24
3. neutron router-create router_01
4. neutron router-gateway-set router_01 admin_floating_net
5. neutron router-interface-add router_01 net01__subnet
6. NET_ID_1=`neutron net-list | awk '/net01/ {print $2}'`
7. neutron port-create $NET_ID_1 --binding:vnic-type macvtap --device_owner nova-compute --name sriov_1
8. neutron port-l
9. neutron port-list
10. port_id_s1=`neutron port-list | awk '/sriov_1/ {print $2}'`
11. NODE_1=node-2.domain.tld
12. nova boot vm1 --flavor m1.small --image ubuntu_14.04 --availability-zone nova:$NODE_1 --nic port-id=$port_id_s1 --key-name cloudkey
13. nova list
  - 36b794e2-5e90-4da4-9470-615429ccfdec | vm1 | ACTIVE | - | Running | net01=10.1.1.3

14. nova migrate vm1
15. nova list
  - 36b794e2-5e90-4da4-9470-615429ccfdec | vm1 | ERROR | - | Running | net01=10.1.1.3

16. nova show vm1
  As we see, it is on node-8
    http://paste.openstack.org/show/506944/

Expected results:
instance has status ACTIVE and disposed on node-7

Actual result:
instance has status ERROR and disposed on node-8

Description of the environment:

cat /etc/fuel_build_id:
 418
cat /etc/fuel_build_number:
 418
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

Additional information:
Also, when I tried to migrate instance from node-7 one time I saw this trace on node-2 http://paste.openstack.org/show/506985/

Diagnostic snapshot http://mos-scale-share.mirantis.com/fuel-snapshot-2016-06-01_13-34-53.tar.gz

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Sergey Nikitin <email address hidden>
Review: https://review.fuel-infra.org/21681

[Sergey Nikitin (snikitin)]

In Newton everything works ok.

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21681
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: 440750981c65244903ab5cc91231d4e7a51ac603
Author: Sergey Nikitin <email address hidden>
Date: Mon Jun 6 13:33:48 2016

Added load of 'pci_requests' and 'numa_topology' during cold migration

These fields are needed for scheduling during cold migration.
But they are lazy-loadable and we need to load them manually.

Change-Id: Ifaa8faa2a215c603022da0ece3dd2c3e51283a0c
Closes-Bug: #1587908

[Roman Podoliaka (rpodolyaka)]

Fix merged ^

[Kristina Berezovskaia (kkuznetsova)]

Verify on:
cat /etc/fuel_build_id:
 482
cat /etc/fuel_build_number:
 482
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8458.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8458.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8742.noarch
 fuel-notify-9.0.0-1.mos8458.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8458.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8742.noarch
 fuel-library9.0-9.0.0-1.mos8458.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8742.noarch

Repeat steps, vm migrate correctly

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: mcp/newton
Change author: Sergey Nikitin <email address hidden>
Review: https://review.fuel-infra.org/33588

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 11.0/ocata
Change author: Sergey Nikitin <email address hidden>
Review: https://review.fuel-infra.org/34440

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: mcp/ocata
Change author: Sergey Nikitin <email address hidden>
Review: https://review.fuel-infra.org/34790

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Roman Podoliaka <email address hidden> on branch: 11.0/ocata
Review: https://review.fuel-infra.org/34440
Reason: 11.0/ocata is deprecated in favor of mcp/ocata

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Sergey Nikitin <email address hidden> on branch: mcp/ocata
Review: https://review.fuel-infra.org/34790
Reason: It fixed in Ocata so we don't need this patch

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Sergey Nikitin <email address hidden> on branch: mcp/newton
Review: https://review.fuel-infra.org/33588
Reason: It fixed in Newton