[regression] libvirtd does not start due to incorrect pre-start section in upstart config

Bug #1587836 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Critical
MOS Linux

Bug Description

with https://review.fuel-infra.org/#/c/21417/

the following was added into upstart conf for libvirtd:

 pre-start script 54
    LIBVIRTD_SYSCONFIG=/etc/default/libvirtd 55
    if [ -f $LIBVIRTD_SYSCONFIG ]; then 56
        . $LIBVIRTD_SYSCONFIG 57
    fi 58
    sockfile="${SOCKFILE:-/var/run/libvirt/libvirt-sock}" 59
    sockfile_check_retries=5 60
    while [ ! -S $sockfile ] ; do 61
        sleep 2 62
        if ! sockfile_check_retries=`expr $sockfile_check_retries - 1`; then 63
            echo "Giving up waiting for $sockfile." 64
            stop; exit 1 65
        fi 66
    done 67
    echo "$sockfile ready." 68
end script

This obviously will never work as pre-start happens before service start section is executed. Thus, this breaks libvirtd service and blocks ALL fuel and MOS developers in master branch.

description: updated
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/libvirt (master)

Fix proposed to branch: master
Change author: Vladimir Kuklin <email address hidden>
Review: https://review.fuel-infra.org/21484

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/libvirt (master)

Reviewed: https://review.fuel-infra.org/21484
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 309a90ad96fd24593611f7747959409f17ce2337
Author: Vladimir Kuklin <email address hidden>
Date: Wed Jun 1 11:42:33 2016

Revert "Wait for socket ready in libvirtd upstart job."

This reverts commit ce1c254775ecba971186cd6b71d0fedfde0b9576 which makes libvirt never ever start.

Change-Id: I2678c12d364659a279b806c4b19ea4cf9b7f0352
Closes-bug: #1587836

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.