Entity Graph "nighbours" method / other methods should return non deleted elements unless required otherwise
Bug #1587301 reported by
Dan Offek
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Vitrage |
New
|
Low
|
Unassigned | ||
Bug Description
Entity Graph "nighbours" method and other methods accept attributes and return the elements accordingly. To get only non deleted elements, one hould add "VProps.IS_DELETED: False".
This is wrong. This attribute should not be passed, and should be the default behavior. Only if "IS_DELETED: True is passed, it should take that into consideration.
Keep in mind during developing the fix, that we should still be able to return ALL of the elements (both deleted and not deleted) if required.
Revision history for this message
| Elisha Rosensweig (elisha-rosensweig) wrote | #1 |
| Changed in vitrage: | |
| importance: | Undecided → Low |
To post a comment you must log in.
It's a bit more complicated than that, since this makes expressing "return both deleted and non-deleted elements" difficult to express generically.
Might be better to support this via special field in the method signature, which adds the key in the method implicitly.