The upload is implemented as functions in a module
Bug #1586874 reported by
Leo Arias
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Snapcraft |
Fix Released
|
Medium
|
Leo Arias |
Bug Description
Just like in bug #1586504, we can improve the upload code by moving the download to the StoreClient object.
[Impact]
* No visual impact for users, the commands are untouched.
* This change improves the existing code, but also allows us to make an easier landing of the macaroons feature.
[Test Case]
* snapcraft login.
* build a snap
* snapcraft upload <path.snap>
* check that os snap was uploaded by going to myapps.
[Regression Potential]
* The upload of snaps might fail.
Changed in snapcraft: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Leo Arias (elopio) |
milestone: | none → 2.10 |
Changed in snapcraft: | |
status: | In Progress → Fix Committed |
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
https:/ /github. com/ubuntu- core/snapcraft/ pull/531