debian/clean: config.log: not found

[jean-christophe manciot]

Ubuntu 16.04 4.4.0-22
Openssh debian 7.2p2-5

 echo --------
 echo Cleaning
 echo --------
 cd git-openssh
 git reset --hard
 git clean -fxd :/
 git fetch --progress --prune origin

 echo -------------------------------------------------------
 echo "Copying Debian control folder in the expected location"
 echo -------------------------------------------------------
 rsync -av ../debian .

 echo --------
 echo Building
 echo --------
 dpkg-buildpackage -m"Jean-Christophe Manciot <email address hidden>"

...
make[1]: Leaving directory '/home/actionmystique/Program-Files/Ubuntu/OpenSSH/git-openssh'
   dh_autoreconf_clean
   dh_clean
/home/actionmystique/Program-Files/Ubuntu/OpenSSH/git-openssh/debian/clean: 1: /home/actionmystique/Program-Files/Ubuntu/OpenSSH/git-openssh/debian/clean: config.log: not found
...

[Colin Watson (cjwatson)]

I think you've somehow managed to make debian/clean executable or something. Regardless, this is entirely unsupported; you can't just randomly copy the debian directory around into an upstream tree and expect things to work out of the box, it often requires non-trivial effort. As such I'm not willing to spend time investigating problems you find when doing this - you will have to work them out for yourself.

[jean-christophe manciot (manciot-jeanchristophe)]

I haven't touch in any way "debian/clean".
Regardless, you (or the person responsible for this) could format the version number in such a way that we could still link it to an upstream commit when it does not match a tag; for instance, there are 7.2p2-4ubuntu1, 7.2p2-4, 7.2p2-5... when the latest tag is 7.2p2, so we can't know which commit matches which version.
However, if the version had a format such as 7.2p3~git20160520.39c0ceca, we would be able to map it to a known commit.

[Colin Watson (cjwatson)]

Regarding debian/clean, I didn't say you necessarily did it intentionally or manually. You could at least check. The symptoms you report are consistent with debian/clean being incorrectly executable.

Regarding the version number, I do! All of those versions are based directly on the upstream 7.2p2 release (git tag V_7_2_P2), not on any newer upstream commit. 7.2p3~gitwhatever would be totally incorrect and inappropriate. Yes, some upstream patches are cherry-picked, but those are all in debian/patches. You can see the git history directly by checking out https://anonscm.debian.org/git/pkg-ssh/openssh.git (the value of Vcs-Git in debian/control).

[Colin Watson (cjwatson)]

... and, furthermore, you will find a tag for each Debian release in that git repository.

[jean-christophe manciot (manciot-jeanchristophe)]

Thanks a lot for clarifying that.