impossible to assign 'virt' role via fuel cli

[Aleksandr Didenko]

Nailgun fails with "500 Server Error: Internal Server Error" when assigning 'virt' role via CLI

Steps to reproduce:

1. Enable 'advanced' feature group in /etc/nailgun/settings.yaml and restart nailgun
2. Create any env (for example with VLAN segmentation)
3. Add any node to this env as 'virt' node:
fuel --env 3 node set --node 2 --role virt
or
fuel2 env add nodes -e 3 -n 2 -r virt

Expected result:
node is added to env

Actual result:
500 Internal Server Error - http://paste.openstack.org/show/505941/

Assigning other roles via CLI works fine:
http://paste.openstack.org/show/505943/

Assigning 'virt' role via UI works fine:
http://paste.openstack.org/show/505942/

Version info:
# shotgun2 short-report
cat /etc/fuel_build_id:
 260
cat /etc/fuel_build_number:
 260
cat /etc/fuel_release:
 10.0
cat /etc/fuel_openstack_version:
 newton-10.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-nailgun-10.0.0-1.mos8768.noarch
 fuel-release-10.0.0-1.mos6349.noarch
 fuel-openstack-metadata-10.0.0-1.mos8768.noarch
 fuel-library10.0-10.0.0-1.mos8471.noarch
 rubygem-astute-10.0.0-1.mos749.noarch
 python-packetary-10.0.0-1.mos140.noarch
 fuelmenu-10.0.0-1.mos282.noarch
 fuel-agent-10.0.0-1.mos293.noarch
 fuel-ui-10.0.0-1.mos2722.noarch
 fuel-setup-10.0.0-1.mos6349.noarch
 nailgun-mcagents-10.0.0-1.mos749.noarch
 fuel-mirror-10.0.0-1.mos140.noarch
 shotgun-10.0.0-1.mos91.noarch
 fuel-bootstrap-cli-10.0.0-1.mos293.noarch
 fuel-migrate-10.0.0-1.mos8471.noarch
 fuel-ostf-10.0.0-1.mos939.noarch
 fuel-plugin-kubernetes-1.0-1.0.0-1.noarch
 fuel-misc-10.0.0-1.mos8471.noarch
 python-fuelclient-10.0.0-1.mos322.noarch
 fuel-10.0.0-1.mos6349.noarch
 fuel-notify-10.0.0-1.mos8471.noarch
 network-checker-10.0.0-1.mos73.x86_64
 fuel-utils-10.0.0-1.mos8471.noarch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/322468

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322468
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1e8faea9c784aaee5987dbe2646cd80f1cd27187
Submitter: Jenkins
Branch: master

commit 1e8faea9c784aaee5987dbe2646cd80f1cd27187
Author: tivaliy <email address hidden>
Date: Sun May 29 08:53:12 2016 +0300

    Align validate roles procedure with 'version' model

    Assigning 'virt' role for nodes requires 'version' model
    in order to check that 'advanced' option is enabled in
    feature group

    Change-Id: Ic80ecd764f72da5ed756ba6ffad7bc060129eb6a
    Closes-Bug: 1586500

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322920

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vitalii Kulanov (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/322920
Reason: Bug is not proposed for mitaka

[Aleksey Kasatkin (alekseyk-ru)]

It is reproduced in mitaka as well: http://paste.openstack.org/show/506542/

So, adding mitaka as affected.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322920
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6a04ecc334f56a2e3f80a87f0c0f0ae474ad2ae3
Submitter: Jenkins
Branch: stable/mitaka

commit 6a04ecc334f56a2e3f80a87f0c0f0ae474ad2ae3
Author: tivaliy <email address hidden>
Date: Sun May 29 08:53:12 2016 +0300

    Align validate roles procedure with 'version' model

    Assigning 'virt' role for nodes requires 'version' model
    in order to check that 'advanced' option is enabled in
    feature group

    Change-Id: Ic80ecd764f72da5ed756ba6ffad7bc060129eb6a
    Closes-Bug: 1586500
    (cherry picked from commit 1e8faea9c784aaee5987dbe2646cd80f1cd27187)

[Dmitry Belyaninov (dbelyaninov)]

Verified on 465 ISO

[root@nailgun ~]# fuel --env 1 node set --node 5 --role virt
Nodes [5] with roles ['virt'] were added to environment 1
[root@nailgun ~]#
[root@nailgun ~]# fuel2 env add nodes -e 1 -n 3 -r virt
Nodes [3] were added to the environment 1 with roles ['virt']
[root@nailgun ~]#
[root@nailgun ~]# fuel node list --env 1
id | status | name | cluster | ip | mac | roles | pending_roles | online | group_id
---+----------+------------------+---------+-------------+-------------------+-------+---------------+--------+---------
 5 | discover | Untitled (56:aa) | 1 | 10.109.10.7 | 64:48:c3:86:56:aa | | virt | 1 | 1
 3 | discover | Untitled (2c:2a) | 1 | 10.109.10.3 | 64:ce:ac:ef:2c:2a | | virt | 1 | 1
[root@nailgun ~]#
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 465
cat /etc/fuel_build_number:
 465
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0