Fuel-library doesn't support Puppet4

[Dmitry Ilyin]

Fuel Library consists mostly of external modules that have a good Puppet4 support,
but some of "internal" modules have not been updates for puppet4 compatibility.

Puppet4 should be supported:
1) RSpec tests of all modules that actually have them
2) Noop tests should be working with both Puppet3 and Puppet4
3) If should be possible to deploy Fuel using the Puppet4 on the managed nodes.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/322279

[Dmitry Teselkin (teselkin-d)]

Related fix proposed to branch: master
Review: https://review.openstack.org/#/c/313092/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/312949

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/320928

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/320929

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/324036

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/324384

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/324724

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324384
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=268fce51fd03d74920f77af3e7062948cc949b7b
Submitter: Jenkins
Branch: master

commit 268fce51fd03d74920f77af3e7062948cc949b7b
Author: Sergey Vasilenko <email address hidden>
Date: Thu Jun 2 13:08:08 2016 +0300

    l23network fixes for puppet4 compatibility.

    Fix inheritance and default parameter definition for puppet classes

    Related-Bug: 1586480
    Change-Id: I193e22d939d6869cfbeb01330d6b722e4d97da34

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326509

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/313092

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/322279

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/324036

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/324724

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326541

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326542

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326543

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326544

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326545

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326546

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326547

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326548

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326549

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326541
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=76f39414c62233b1f32f4b82b04be8c0a5355b2e
Submitter: Jenkins
Branch: master

commit 76f39414c62233b1f32f4b82b04be8c0a5355b2e
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:41:17 2016 +0300

    Puppet4 support: refactor vips

    The generate_vips function is refactored to work in pair
    with the create_resources functions. It's much better for testing
    and debugging.
    Input data of the vurual ip definition is split into many parameters
    and the generate vips function is tought to support the changed
    interfacs as well as to work with Puppet4's undef values.

    Change-Id: If865f39a3d1c22efa6df8035a4e92004fcf2ffb6
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/326509

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327038
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a4c4e448134da3eb03e3465ffa6918e2b6c6dddd
Submitter: Jenkins
Branch: master

commit a4c4e448134da3eb03e3465ffa6918e2b6c6dddd
Author: Dmitry Ilyin <email address hidden>
Date: Wed Jun 8 14:33:57 2016 +0300

    Puppet4 support: cluster module

    * Fix rspec tests in the cluster module

    Related-Bug: 1586480
    Fuel-CI: disable
    Change-Id: I56462596cd5b636d8e7edd146f0ce14dd5471d4c

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/331791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326543
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9c5fc0f142ba894e6c5108d6c8bb78e54595b9c0
Submitter: Jenkins
Branch: master

commit 9c5fc0f142ba894e6c5108d6c8bb78e54595b9c0
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:50:49 2016 +0300

    Puppet4 support: l23network spec

    * Finish l23network refactoring

    Fuel-CI: disable
    Change-Id: If6d0ca88f4ba87b52e24281eb0f59b5943ec6ca0
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326558
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=50eb9b76ec51ad5e3405d698434efe1394fe8434
Submitter: Jenkins
Branch: master

commit 50eb9b76ec51ad5e3405d698434efe1394fe8434
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:58:37 2016 +0300

    Puppet4 support: l23network manifests

    * Misc fixes in the l23 manifests

    Related-Bug: 1586480
    Change-Id: I352d78203f2f62b6780c3b1cbcb487c89b0c0ebe

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/333570

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/333571

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/333572

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326542
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7a312e222e84d3df5ff6a48e55b4e5588789e201
Submitter: Jenkins
Branch: master

commit 7a312e222e84d3df5ff6a48e55b4e5588789e201
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:50:19 2016 +0300

    Puppet4 support: l23network library

    * Fixes in the l23 module's ruby liraries

    Related-Bug: 1586480
    Change-Id: Iff68510e2e6dfd55283723bfb80343d6ba8cc70e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333570
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=29ab657707855dc294dfedcbe6d9673d4ff557a5
Submitter: Jenkins
Branch: master

commit 29ab657707855dc294dfedcbe6d9673d4ff557a5
Author: Dmitry Ilyin <email address hidden>
Date: Thu Jun 23 23:13:11 2016 +0300

    Puppet4 support: l23network spec updates

    * Fixes in the l23 module's ruby liraries

    Change-Id: Ib08c1c81255bdbdf557bfdf48f2ad409bbd8957a
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/331791
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2692dfa34a40cee78f025242e5b99180495690a1
Submitter: Jenkins
Branch: master

commit 2692dfa34a40cee78f025242e5b99180495690a1
Author: Dmitry Ilyin <email address hidden>
Date: Mon Jun 20 21:10:17 2016 +0300

    Puppet4 support: cobbler

    * Fix cobbler specs and manifests

    Change-Id: I75d59e947f9bfd21dfaaef44a482af0f984025c6
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333571
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=44ccfe8e43aea2f936f015c72b3483cf14f53c7c
Submitter: Jenkins
Branch: master

commit 44ccfe8e43aea2f936f015c72b3483cf14f53c7c
Author: Dmitry Ilyin <email address hidden>
Date: Thu Jun 23 21:44:24 2016 +0300

    Puppet4 support: cgroups

    Change-Id: I6292bcc7807a65da3a61905655e3527874ae6ab2
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333572
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4d8ed87a30dbf62b7ab6d97bd889984f022f6ca3
Submitter: Jenkins
Branch: master

commit 4d8ed87a30dbf62b7ab6d97bd889984f022f6ca3
Author: Dmitry Ilyin <email address hidden>
Date: Thu Jun 23 23:30:17 2016 +0300

    Puppet4 support: sysfs

    Change-Id: I9196540e692547a86b3d16842beda939cbfec4e3
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/326549
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/326548
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/362186

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/356728
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=bfb4b51834e98e75fdd54aac7252da7b9a7a78ae
Submitter: Jenkins
Branch: master

commit bfb4b51834e98e75fdd54aac7252da7b9a7a78ae
Author: Dmitry Ilyin <email address hidden>
Date: Fri Aug 26 16:18:56 2016 -0500

    Puppet4 support: cluster module

    Separate fixes

    Related-Bug: 1586480
    Change-Id: I9fb6fe6a0d0b283af5b6783e022cd5d5052addea

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/363169

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/363172

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/363189

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/358071
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=39cd163c4414b9268625c50d7e7716e9ed18c980
Submitter: Jenkins
Branch: master

commit 39cd163c4414b9268625c50d7e7716e9ed18c980
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:54:11 2016 +0300

    Puppet4 support: multiple modules

    * Fixes for the openstack tasks and openstack
      modules.
    * Fixes for fuel tasks.
    * Fixes for openstack modules
    * Noop tests fixes.

    Puppet4 support: common spec

    Remove dynamic nova-compute service lookup because the performance
    impact of it was too high. Now this value is being statically
    chosen by the OS family name.

    Puppet4 support: cobbler

    * Fix duplicate declarations of systemd services
    * upstream dns servers should be an array

    Puppet4 support: rsyslog

    Fix duplicate rsyslog service
    between haproxy and logging tasks
    Add tests to ensure that service is present

    Puppet4 support: ntp

    Fix ntp service duplicate declaration

    Puppet4 support: horizon

    Fix forgotten include of nova::params

    Puppet4 support: apache

    Fix broken containment and ordering

    Puppet4 support: mysql

    Remove duplicate declaration of the access file

    Puppet4 support: keystone

    user_admin_role should be array

    Puppet4 support: openstack controller

    Add forgotten include of nova::params

    Puppet4 support: server_config

    * Check for both undef and empty string value for mtu
    * tunel_id_ranges should be array

    Puppet4 support: rabbitmq

    Add forgotten vhost name variable

    Puppet4 support: tools

    Rewrite badly writtent spec file variables.

    Related-Bug: 1586480
    Change-Id: Ia9b474a7076365c0fcad2b55c65e8305477a4647

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326549
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d03bf40521b652805928a0f57ec983df7f599370
Submitter: Jenkins
Branch: master

commit d03bf40521b652805928a0f57ec983df7f599370
Author: Dmitry Ilyin <email address hidden>
Date: Tue Jun 7 17:55:29 2016 +0300

    Puppet4 support: support files

    * enable both Puppet4 and Puppet3 noop tests
    * Rake support
    * Module and gem versions
    * Script improvements

    Change-Id: Ib3db0e8491a34851ba86f9364131d84ed7abf2ee
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363189
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=cb169f890609b3f3bb05b4d231d9bf4e13b5b9e5
Submitter: Jenkins
Branch: master

commit cb169f890609b3f3bb05b4d231d9bf4e13b5b9e5
Author: Dmitry Ilyin <email address hidden>
Date: Tue Aug 30 15:26:17 2016 -0500

    Puppet4 support: add bug message

    Add todo about mysq_access problem

    Change-Id: I0a77b941202a065f33a18f2e2bf38afbd879fcd8
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/363169

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/363172

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/363902

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/363902

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/363973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/358070
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=24048bc2f55e08d50a59a3cec44b52b67f3658eb
Submitter: Jenkins
Branch: master

commit 24048bc2f55e08d50a59a3cec44b52b67f3658eb
Author: Dmitry Ilyin <email address hidden>
Date: Wed Aug 31 17:59:15 2016 -0500

    Puppet4 support: noop tests fixes

    * Disable STRICT_VARIABLE checks.
    * Switch to the Puppet version 4.5.0
    * Disable Noop tests for Puppet4
      they should be moved to a separate job

    Related-Bug: 1586480
    Change-Id: Ib540dc243647fffeb4b2d101f9f902b9e4c1c104

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363973
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b16815d63760659619fe5c57427d05bffbc05dd5
Submitter: Jenkins
Branch: master

commit b16815d63760659619fe5c57427d05bffbc05dd5
Author: Dmitry Ilyin <email address hidden>
Date: Wed Aug 31 17:56:02 2016 -0500

    Puppet4 support: l23network fixes

    * nic_whitelist_to_json function should return nil if there are no
      whitelists.
    * Remove the mutators for the frozen strings in the validator

    Change-Id: I89b2a487740fbe21de730527351bd33595403d42
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/364406

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/365028

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364406
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7d2edeefc14e60a68d6b8ff8279f0db1b8e0d6a7
Submitter: Jenkins
Branch: master

commit 7d2edeefc14e60a68d6b8ff8279f0db1b8e0d6a7
Author: Dmitry Ilyin <email address hidden>
Date: Thu Sep 1 10:45:26 2016 -0500

    Puppet4 support: fix noop launcher.

    Prevent false positive results in cases when something
    is wrong with the environment and tests have not started at all.

    Change-Id: Icb8cd6ebe523ef51505ab2c7daadb10c62aa220f
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365028
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a39067f7b05cbbe74792bbe757f241cec95ae57f
Submitter: Jenkins
Branch: master

commit a39067f7b05cbbe74792bbe757f241cec95ae57f
Author: Dmitry Ilyin <email address hidden>
Date: Fri Sep 2 10:24:13 2016 -0500

    Puppet4 support: nic_passthrough_whitelist

    Change-Id: I7be4b1e976a7bb5ab76924a20ff3872aa6371fab
    Related-Bug: 1586480

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/366590

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367102

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/366590
Reason: Combined in other cherry-pick

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367106

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367169

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367102
Reason: implemented in other change

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367106
Reason: implemented in other change

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367169
Reason: Too big to debug

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367783

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367848

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368578

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368759

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368813

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368876

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/368876
Reason: wrong change

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367783
Reason: Project cancelled.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367848
Reason: Project cancelled.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/368578
Reason: Project cancelled.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/368759
Reason: Project cancelled.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Richard Berwald (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/368813
Reason: Project cancelled.

[Dmitry Klenov (dklenov)]

As LCM strategy has been changed, Puppet4 compatibility is not needed any more for Mitaka.