User login no spaces messages is misleading

[Kathy Lussier]

Back in the olden days of late 2012, a promising new Evergreen developer going by the name of Dan Pearl introduced code in bug 1086064 to eliminate the requirement to remove any spaces from a barcode when users log in. As part of the branch, he also removed the "no extra spaces" message from the login screen.

However, he was asked to hold off on changing this message because string changes in point releases generate a lot of churn for translators.

Fast forward 7 major releases later, and our modern-day Evergreen system still has a misleading message telling users they cannot enter spaces when logging in by barcode.

It is time we say loudly and clearly that we want to restore truth to our login pages and let our users know that yes, they can use spaces in their barcodes!

Targeting this bug towards 2.next so that we don't miss it for our next release.

[Terran McCanna (tmccanna)]

+1

[Chris Sharp (chrissharp123)]

Working branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1586221_user_login_no_spaces_message

Since I'm unfamiliar with the details of how translations work, I may have made the same error that Dan Scott called out in his comment (https://bugs.launchpad.net/evergreen/+bug/1086064/comments/6), so hopefully someone will be able to correct that if so.

[Kathy Lussier (klussier)]

Thank you Chris. I've signed off on your branch and merged it to master.

For further explanation on Dan Scott's comment, the issue is that the code was backported to previous releases, and we try to avoid backporting code with string changes unless it is fixing a bug. Since your code was merged to master and was not backported, there are no issues with changing the string.