Fuel-web: Please remove hardcode from base_serializers.py

[Andrey Kirilochkin]

We need that vcenter_hash on all roles. We have to have this hash on custom role. But have it hardcoded in base_serializers.py only for some roles.

https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/orchestrator/base_serializers.py#L151-L161

[Oleksiy Molchanov (omolchanov)]

Hi, what release are we talking about?

[Andrey Kirilochkin (andreika-mail)]

9.0 kilo

[Andrey Maximov (maximov)]

hardcode was introduced in https://review.openstack.org/#/c/202912/

[Andriy Popovych (popovych-andrey)]

>> hardcode was introduced in https://review.openstack.org/#/c/202912/

1. No, it was implemented in https://review.openstack.org/#/c/147786
2. Let's not call it hardcode. We had predefined set of roles where vmware attributes was needed to keep deployment scenarios more clear.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/324342

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/324528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324342
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=61023242c02bb064872424b3e57d5c28a372c0fb
Submitter: Jenkins
Branch: master

commit 61023242c02bb064872424b3e57d5c28a372c0fb
Author: Andriy Popovych <email address hidden>
Date: Thu Jun 2 13:09:00 2016 +0300

    Remove predefined roles for vmware serialization

    Vmware attributes hash should be present for all roles.

    Change-Id: I5547365b9ccb16200c6a8f0efcbdaad69c07689e
    Closes-Bug: #1586185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324528
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ddf530fca8199560e185ee30052631d7f5dc5e48
Submitter: Jenkins
Branch: stable/mitaka

commit ddf530fca8199560e185ee30052631d7f5dc5e48
Author: Andriy Popovych <email address hidden>
Date: Thu Jun 2 13:09:00 2016 +0300

    Remove predefined roles for vmware serialization

    Vmware attributes hash should be present for all roles.

    Change-Id: I5547365b9ccb16200c6a8f0efcbdaad69c07689e
    Closes-Bug: #1586185

[Kyrylo Romanenko (kromanenko)]

Verified on ISO
shotgun2 short-report
cat /etc/fuel_build_id:
 465
cat /etc/fuel_build_number:
 465
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8454.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8454.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8742.noarch
 fuel-notify-9.0.0-1.mos8454.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8454.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8742.noarch
 fuel-library9.0-9.0.0-1.mos8454.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8742.noarch

[Andrey Kirilochkin (andreika-mail)]

cool, thank you so much