Cinder

Typo in function call manager.py

Bug #1586062 reported by James Conroy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
James Conroy
Mitaka
Fix Released
High
James Conroy

Bug Description

The manage_existing_snapshot function has a typo on line 3611 (mitaka branch).
Spelling "exisiting" should be "existing".

See original description
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

This is not a bug, but feel free to submit a patch to change that method name to correct the spelling.

Changed in cinder:
status: New → Invalid
Revision history for this message
James Conroy (jayconroy) wrote :

2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher Traceback (most recent call last):
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/venv/cinder-20160523T095521Z/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 138, in _dispatch_and_reply
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher incoming.message))
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/venv/cinder-20160523T095521Z/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 185, in _dispatch
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/venv/cinder-20160523T095521Z/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 127, in _do_dispatch
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/venv/cinder-20160523T095521Z/lib/python2.7/site-packages/cinder/volume/manager.py", line 3611, in manage_existing_snapshot
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher return self.manager.manage_exisiting_snapshot(ctxt, snapshot, ref=ref)
2016-05-26 09:25:14.885 31217 ERROR oslo_messaging.rpc.dispatcher AttributeError: 'VolumeManager' object has no attribute 'manage_exisiting_snapshot'

summary: - Typo in cinder/volume/manager.py mitaka
+ Typo in cinder/volume/manager.py manage_exisiting_snapshot causes
+ failure to manage snapshot
Scott DAngelo (scott-dangelo)
Changed in cinder:
assignee: nobody → Scott DAngelo (scott-dangelo)
James Conroy (jayconroy)
Changed in cinder:
assignee: Scott DAngelo (scott-dangelo) → Jay Conroy (james-conroy)
Eric Harney (eharney)
Changed in cinder:
status: Invalid → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/321606

Sean McGinnis (sean-mcginnis)
Changed in cinder:
status: Confirmed → Invalid
Scott DAngelo (scott-dangelo)
Changed in cinder:
importance: Undecided → High
James Conroy (jayconroy)
summary: - Typo in cinder/volume/manager.py manage_exisiting_snapshot causes
- failure to manage snapshot
+ failure to manage snapshot caused by manage_exisiting_snapshot in
+ cinder/volume/manager.py manage_exisiting_snapshot causes
summary: failure to manage snapshot caused by manage_exisiting_snapshot in
- cinder/volume/manager.py manage_exisiting_snapshot causes
+ cinder/volume/manager.py
Scott DAngelo (scott-dangelo)
summary: - failure to manage snapshot caused by manage_exisiting_snapshot in
- cinder/volume/manager.py
+ Typo causes failure to manage snapshot in v1
Scott DAngelo (scott-dangelo)
summary: - Typo causes failure to manage snapshot in v1
+ Typo causes failure to manage snapshot with v1 RPC
James Conroy (jayconroy)
summary: - Typo causes failure to manage snapshot with v1 RPC
+ Typo in function call manager.py
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/mitaka)

Reviewed: https://review.openstack.org/321606
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7ba7b5595701baf47c4199bac593d023223191ec
Submitter: Jenkins
Branch: stable/mitaka

commit 7ba7b5595701baf47c4199bac593d023223191ec
Author: Jay Conroy <email address hidden>
Date: Thu May 26 16:08:40 2016 +0100

    Fix typo in function call manager.py

    The manage_existing_snapshot function has a typo in mitaka
    (lines 3610-3611).
    Not a cherry-pick because this code has been removed on
    branch master.
    Remove the "i" in "exisiting" to fix the typo.

    Change-Id: Ia370a49b945d7a3918d766e118d02ad2649ef4ba
    Closes-bug: 1586062

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 8.1.0

This issue was fixed in the openstack/cinder 8.1.0 release.

Eric Harney (eharney)
Changed in cinder:
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.