BGPaaS: CN crash in RoutePathReplicator::RouteListener

[amit surana]

3.0.2 b41
core at:

core is in 10.84.5.112:/cs-shared/bugs/<bug-id>/

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-control'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007f7199177cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
Traceback (most recent call last):
  File "/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py", line 63, in <module>
    from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt
#0 0x00007f7199177cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007f719917b0d8 in __GI_abort () at abort.c:89
#2 0x00007f7199170b86 in __assert_fail_base (fmt=0x7f71992c1830 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n",
    assertion=assertion@entry=0xc9351b "result.second", file=file@entry=0xcaeb30 "controller/src/bgp/routing-instance/routepath_replicator.cc",
    line=line@entry=637,
    function=function@entry=0xcaeca0 <RoutePathReplicator::RouteListener(TableState*, DBTablePartBase*, DBEntryBase*)::__PRETTY_FUNCTION__> "bool RoutePathReplicator::RouteListener(TableState*, DBTablePartBase*, DBEntryBase*)") at assert.c:92
#3 0x00007f7199170c32 in __GI___assert_fail (assertion=0xc9351b "result.second",
    file=0xcaeb30 "controller/src/bgp/routing-instance/routepath_replicator.cc", line=637,
    function=0xcaeca0 <RoutePathReplicator::RouteListener(TableState*, DBTablePartBase*, DBEntryBase*)::__PRETTY_FUNCTION__> "bool RoutePathReplicator::RouteListener(TableState*, DBTablePartBase*, DBEntryBase*)") at assert.c:101
#4 0x00000000005f07c8 in RoutePathReplicator::RouteListener (this=0x1999b60, ts=0x7f716800b7f0, root=<optimized out>, entry=0x7f716800e530)
    at controller/src/bgp/routing-instance/routepath_replicator.cc:637
#5 0x0000000000c1b9fa in operator() (a1=0x7f716800e530, a0=0x7f71640188e0, this=0x7f7191defaa0) at /usr/include/boost/function/function_template.hpp:767
#6 RunNotify (entry=0x7f716800e530, tpart=0x7f71640188e0, this=0x7f7164018390) at controller/src/db/db_table.cc:114
#7 DBTableBase::RunNotify (this=<optimized out>, tpart=tpart@entry=0x7f71640188e0, entry=entry@entry=0x7f716800e530) at controller/src/db/db_table.cc:204
#8 0x0000000000c1e028 in DBTablePartBase::RunNotify (this=this@entry=0x7f71640188e0) at controller/src/db/db_table_partition.cc:47
#9 0x0000000000c1a1f0 in DBPartition::QueueRunner::Run (this=0x7f7188029db0) at controller/src/db/db_partition.cc:209
#10 0x0000000000689b3f in TaskImpl::execute (this=0x7f71929b6740) at controller/src/base/task.cc:262
#11 0x00007f7199f4eb3a in ?? () from /usr/lib/libtbb.so.2
#12 0x00007f7199f4a816 in ?? () from /usr/lib/libtbb.so.2
#13 0x00007f7199f49f4b in ?? () from /usr/lib/libtbb.so.2
#14 0x00007f7199f460ff in ?? () from /usr/lib/libtbb.so.2
#15 0x00007f7199f462f9 in ?? () from /usr/lib/libtbb.so.2
#16 0x00007f719a16a182 in start_thread (arg=0x7f7191df0700) at pthread_create.c:312
#17 0x00007f719923b47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) q

[amit surana (asurana-t)]

crash seen when AAP/interface-static route is attached to BGPaaS VMI to advertise the loopback IP.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20687
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20688
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20687
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20688
Committed: http://github.org/Juniper/contrail-controller/commit/3e5ccaba054f9717fb8a556ff7b3c563369fccb7
Submitter: Zuul
Branch: master

commit 3e5ccaba054f9717fb8a556ff7b3c563369fccb7
Author: Nischal Sheth <email address hidden>
Date: Thu May 26 14:44:25 2016 -0700

Ignore label when comparing forwarding info for BgpPaths

There could be transient scenarios where the route for a ResolverNexthop
has 2 BgpPaths with same nexthop and different labels. If PathResolver
treats these as unique and adds a resolved path corresponding to each of
them, the RoutePathReplicator will see 2 secondary paths with identical
RtReplicated::SecondaryRouteInfo and assert.

Change-Id: Ie6c293bfc16a455596840c8000a61fea4e83b56d
Closes-Bug: 1585891

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20687
Committed: http://github.org/Juniper/contrail-controller/commit/f6abc8d5521bef1b77f12a82cb7223d80d63da9f
Submitter: Zuul
Branch: R3.0

commit f6abc8d5521bef1b77f12a82cb7223d80d63da9f
Author: Nischal Sheth <email address hidden>
Date: Thu May 26 14:44:25 2016 -0700

Ignore label when comparing forwarding info for BgpPaths

There could be transient scenarios where the route for a ResolverNexthop
has 2 BgpPaths with same nexthop and different labels. If PathResolver
treats these as unique and adds a resolved path corresponding to each of
them, the RoutePathReplicator will see 2 secondary paths with identical
RtReplicated::SecondaryRouteInfo and assert.

Change-Id: Ie6c293bfc16a455596840c8000a61fea4e83b56d
Closes-Bug: 1585891