BGPaaS: CN crash in BgpPath::PathCompare

[amit surana]

3.02 b 41

core is in 10.84.5.112:/cs-shared/bugs/<bug-id>/

(gdb) bt
#0 BgpPath::PathCompare (this=0x7fdd4c1aa7f0, rhs=..., allow_ecmp=allow_ecmp@entry=true) at controller/src/bgp/bgp_path.cc:53
#1 0x00000000005d2d5b in ResolverPath::UpdateResolvedPaths (this=this@entry=0x7fdd841916f0) at controller/src/bgp/routing-instance/path_resolver.cc:969
#2 0x00000000005d350c in PathResolverPartition::ProcessResolverPathUpdateList (this=0x7fdda804dbc0)
    at controller/src/bgp/routing-instance/path_resolver.cc:713
#3 0x000000000068ee07 in operator() (this=<optimized out>) at /usr/include/boost/function/function_template.hpp:767
#4 TaskTrigger::WorkerTask::Run (this=0x7fdd8417b9d0) at controller/src/base/task_trigger.cc:22
#5 0x0000000000689b3f in TaskImpl::execute (this=0x7fddcfc5eb40) at controller/src/base/task.cc:262
#6 0x00007fddd723eb3a in ?? () from /usr/lib/libtbb.so.2
#7 0x00007fddd723a816 in ?? () from /usr/lib/libtbb.so.2
#8 0x00007fddd7239f4b in ?? () from /usr/lib/libtbb.so.2
#9 0x00007fddd72360ff in ?? () from /usr/lib/libtbb.so.2
#10 0x00007fddd72362f9 in ?? () from /usr/lib/libtbb.so.2
#11 0x00007fddd745a182 in start_thread (arg=0x7fddaf7fd700) at pthread_create.c:312
#12 0x00007fddd652b47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

[amit surana (asurana-t)]

crash is seen when a prefix is advertised via BGP (from BGPaaS VM) and via XMPP (AAP/static-route).

In this specific case, prefix on the lo0 interface of the BGPaaS VM was being advertised via BGP and also via XMPP because of AAP config attached to the BGPaaS VMI. In general, the crash could be seen if a prefix has a next-hop that itself has another next-hop.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20672
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20673
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20672
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20673
Committed: http://github.org/Juniper/contrail-controller/commit/121913b7f31736b9650cbfe1e4b61db4cbc170ef
Submitter: Zuul
Branch: R3.0

commit 121913b7f31736b9650cbfe1e4b61db4cbc170ef
Author: Nischal Sheth <email address hidden>
Date: Thu May 26 09:32:28 2016 -0700

Do not resolve paths with nexthop same as prefix

Change-Id: I10d8f51738eddcd8a62c31afddef19a9f41b1934
Closes-Bug: 1585832

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20672
Committed: http://github.org/Juniper/contrail-controller/commit/5aaca18a3c5da9d3546e110c440f34a54a9e27fb
Submitter: Zuul
Branch: master

commit 5aaca18a3c5da9d3546e110c440f34a54a9e27fb
Author: Nischal Sheth <email address hidden>
Date: Thu May 26 09:32:28 2016 -0700

Do not resolve paths with nexthop same as prefix

Change-Id: I10d8f51738eddcd8a62c31afddef19a9f41b1934
Closes-Bug: 1585832