[dashboard] [glare] Specifying abstract base class in the dynamic ui does not yield all of it's descendants in drop-down

Bug #1585812 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev

Bug Description

Whenever user specifies a class-dependency in the UI definitions of a package — only that class itself is presented as an option in the dynamic-ui. However engine and api allow to use any package, that has classes, that inherit from the specified class.

Expected result: specifying a class in the UI definitions fetches all the classes, that implement/inherit given class

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321255

Changed in murano:
status: Confirmed → In Progress
Changed in murano:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/321255
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=2857c8f4a3eeb6c2db1d2572422ca4c0673ce1ba
Submitter: Jenkins
Branch: master

commit 2857c8f4a3eeb6c2db1d2572422ca4c0673ce1ba
Author: Kirill Zaitsev <email address hidden>
Date: Thu May 26 00:49:07 2016 +0300

    Fetch class descendants in the dynamic_ui from glare

    Before this change whenever a murano-class dependency was specified in
    the ui definition of a package, only packages that contained those
    specific fqns were fetched from API, even though the information about
    inheritance is available in the glare back-end.

    With this change dashboard also fetches all the packages, that have
    classes, that inherit from the specified package. This change also
    alters the way absence of a package is handled. It's now specified as an
    empty field with explanation, rather then a django message. This allows
    having only partial dependencies and skipping optional dependencies
    altogether

    Change-Id: I6632f72ca260c26a116b3aa4608d9592d0f1cbce
    Closes-Bug: #1585812

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/murano-dashboard 3.0.0.0b2

This issue was fixed in the openstack/murano-dashboard 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.