Track properties dialog does not modify track key

Bug #1585769 reported by Justin Loser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
RJ Skerry-Ryan

Bug Description

Mixxx 2.0

For the auto-key detection feature.

From my original post at the forums:

"I love the new key detection feature, but cannot find a way to UPDATE it, especially if it is wrong.

Case in point - on track I loaded today has the key listed as "D" (major), Unfortunately, the song is ACTUALLY in E minor. I have tried to update it in the properties tab for the track but alas, it remains in D even after correcting. So one of a few things needs to happen: 1) I'm missing something on updating to the correct key and can fix this; 2) The key detection is somehow permanently changing the key in the library and cannot be changed 3) Is there a way to have the ENTIRE track analyzed closer? I do NOT have fast detection enabled. 4) Something else, and I am open to suggestions"

Bottom line - there needs to be a way to override the key of the song as detected, no differently than if you change the artist name, or corrected a spelling in a track, etc.

I suppose this has to somehow be backward compatible with the Camelot detection structure as well, but I'll leave that to the coder pros :)

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks for the report!

I can confirm that the track properties dialog can't seem to edit the key -- looks like we broke that at some point. I'm pretty sure it worked when the feature first went in.

You can edit the key from the library table in the key column by clicking once, pausing then clicking again.

Revision history for this message
Justin Loser (loserfamily6) wrote :

That seemed to have worked, as a work around, and I will continue to use that. Thanks for the hint, and I look forward to the correction in an upcoming version!

RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
status: New → In Progress
importance: Undecided → Low
summary: - Key Detection Correction/Override
+ Track properties dialog does not modify track key
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

m_pLoadedTrack->setKeyText(...) is missing in DlgTrackInfo::saveTrack()

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 2.1.0
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :
Changed in mixxx:
status: In Progress → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8559

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.