cascade delete in cinderclient is working incorrect

[wanghao]

Now we have implemented cascade deleting in cinderclient, but argument "--cascade" is not working correctly.

Reproduce step:

1.Create volume and snapshot with it:

cinder snapshot-list
+--------------------------------------+--------------------------------------+-----------+------+------+
| ID | Volume ID | Status | Name | Size |
+--------------------------------------+--------------------------------------+-----------+------+------+
| 0be3d952-a1a2-4d42-b6f2-66aa64f3191a | 6ede3a57-5d0d-4dd4-9642-3b70cb7bc5c9 | available | - | 1 |
+--------------------------------------+--------------------------------------+-----------+------+------+

2.Delete this volume with "--cascade false/False", it should be failed, but now we can delete the volume and snapshot successfully:

cinder delete --cascade false 6ede3a57-5d0d-4dd4-9642-3b70cb7bc5c9
Request to delete volume 6ede3a57-5d0d-4dd4-9642-3b70cb7bc5c9 has been accepted.

cinder snapshot-list
+--------------------------------------+--------------------------------------+----------+------+------+
| ID | Volume ID | Status | Name | Size |
+--------------------------------------+--------------------------------------+----------+------+------+
| 0be3d952-a1a2-4d42-b6f2-66aa64f3191a | 6ede3a57-5d0d-4dd4-9642-3b70cb7bc5c9 | deleting | - | 1 |
+--------------------------------------+--------------------------------------+----------+------+------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/320809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320809
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=86fe5617aaaf3344dc399a946d29ad7ec3414511
Submitter: Jenkins
Branch: master

commit 86fe5617aaaf3344dc399a946d29ad7ec3414511
Author: wanghao <email address hidden>
Date: Wed May 25 15:11:37 2016 +0800

    Fixing parsing problem of cascade in client

    We have implemented cascade deleting volume in CLI now,
    but there's still something that should be improved:

    1. A parsing problem of cascade is existing that always
    evaluate parameter to True.

    So now change the cascade parameter to a flag that don't
    accept value anymore.

    If user want to delete volume with snapshot, just need to
    use 'cinder delete --cascade [volume_id]'.

    Change-Id: I92e9400d5d7fbb741607bdbde7ac0c0667fca85d
    Closes-Bug: #1585441
    Implements: blueprint support-deleting-vols-with-snps-in-cli

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.