environSuite invalid character \"\\\\\" in host name

[Curtis Hovey]

As seen in
    http://reports.vapour.ws/releases/issue/57448b86749a564672a442fe

environSuite tests report invalid character \"\\\\\" in host name.

Many tests in this suite failed like this

environ_whitebox_test.go:755:
    // Since there are no nodes, the attempt to allocate one returns a
    // 409: Conflict.
    c.Check(err, gc.ErrorMatches, ".*409.*")
... error string = "invalid default tools URL file://c:\\users\\admini~1\\appdata\\local\\temp\\tmptuup2o\\gogo\\tmp-juju-testutzsnv\\check-8674665223082153551\\14/tools: parse file://c:\\users\\admini~1\\appdata\\local\\temp\\tmptuup2o\\gogo\\tmp-juju-testutzsnv\\check-8674665223082153551\\14/tools: invalid character \"\\\\\" in host name"
... regex string = ".*409.*"

[Curtis Hovey (sinzui)]

This is not a dupe because the issue is in still happening as shown in
    http://reports.vapour.ws/releases/issue/57448b86749a564672a442fe

[Horacio Durán (hduran-8)]

I clearly missed something when backporting the previous fix.

This is caused by people concatenating strings by hand for file uris

Look for "file:///" + somePath + "/something else"

[Anastasia (anastasia-macmood)]

Similar approach to https://github.com/juju/juju/pull/5395/files needs to be taken for all occurrences where paths are specified.

[Cheryl Jennings (cherylj)]

PR: https://github.com/juju/juju/pull/5573

[Cheryl Jennings (cherylj)]

This was not seen in the latest CI run: http://reports.vapour.ws/releases/4039/job/run-unit-tests-win2012-amd64/attempt/2487

[Anastasia (anastasia-macmood)]

Do we still have this on master or is it no longer valid?