[LCM][Task idempotecy] The task "ironic-compute" is not idempotent

[Sergey Novikov]

Steps to reproduce:
 1. Deploy env with 1 controller + 1 compute + 1 ironic node
 2. Rerun task "ironic-compute" against some controller node
 # Run task via fuel CLI client
 >fuel node --node-id <controller_id> --tasks ironic-compute
 #or the direct run of corresponding puppet manifest on controller node
 >puppet apply --noop /etc/puppet/modules/openstack_tasks/examples/ironic/ironic-compute.pp

Expected results: No resource changes
Actual result: there are many resource changes (please take a look at http://paste.openstack.org/show/498600/)

Description of the environment:
env was built from ISO MOS 9.0 #392

[Sergey Novikov (snovikov)]

jfyi,
The task "primary-openstack-controller" conflicts with task "ironic-compute". If task "primary-openstack-controller" is applied after executing "ironic-compute", we'll see the same resource changes:
      - Nova_config[database/max_retries]
      - Nova_config[database/max_pool_size]
      - Nova_config[database/max_overflow]
      - Nova_config[DEFAULT/notify_on_state_change]
      - Nova_config[DEFAULT/notification_driver]
      - Nova_config[cinder/catalog_info]
      - Nova_config[database/idle_timeout]
      - Nova_config[DEFAULT/allow_resize_to_same_host]
      - Nova_config[DEFAULT/use_stderr]
      - Nova_config[glance/api_servers]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/322835

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322835
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=787d8ffb9335c792a9e8f8bfd63610c7ec478f7f
Submitter: Jenkins
Branch: master

commit 787d8ffb9335c792a9e8f8bfd63610c7ec478f7f
Author: Bartosz Kupidura <email address hidden>
Date: Mon May 30 15:59:06 2016 +0200

    Set same values from ironic-compute and openstack-controller

    To ensure that manifests are idempotent we need to pass same
    variables from different manifests.

    This change will fix issue with ironic-compute task
    and openstack-controller task.

    Change-Id: Ib486d9d9b8b3fc9b951b75b4b4fc37c484250e6a
    Closes-Bug: #1585197

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/325130

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325130
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6ea3c161d05ca3677a060bcfa0aeb53f2d06b649
Submitter: Jenkins
Branch: stable/mitaka

commit 6ea3c161d05ca3677a060bcfa0aeb53f2d06b649
Author: Bartosz Kupidura <email address hidden>
Date: Mon May 30 15:59:06 2016 +0200

    Set same values from ironic-compute and openstack-controller

    To ensure that manifests are idempotent we need to pass same
    variables from different manifests.

    This change will fix issue with ironic-compute task
    and openstack-controller task.

    Change-Id: Ib486d9d9b8b3fc9b951b75b4b4fc37c484250e6a
    Closes-Bug: #1585197
    (cherry picked from commit 787d8ffb9335c792a9e8f8bfd63610c7ec478f7f)

[Sergey Novikov (snovikov)]

Verified on mos 9.0 iso # 449