tagging previously borrowed items in metarecord searches fails

Bug #1584801 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.9
Fix Released
Medium
Unassigned

Bug Description

If the opac.search.tag_circulated_items library setting is turned on and a user who has opted into storing circulation history logs into the public catalog and does a search, results that the user has previously borrowed are tagged as such.

However, this does not work when the search is a metarecord search (i.e., when the group formats and editions box is checked). The query that identifies results that should be tagged fails with the following error:

open-ils.cstore ERROR: Unable to look up core class mmsm

The correct class is actually mmrsm.

Evergreen 2.9 and later

Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1584801_metarecord_searches_tag_circs branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1584801_metarecord_searches_tag_circs

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.10.4
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Kathy Lussier (klussier) wrote :

Looks good Galen! I have a follow-up question before merging.

In my testing, I found that, with the patch, the "I have checked this item out before" message appears on the initial metabib results page but not on the results for the grouped record. Is that the expected behavior?

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for testing!

To answer your question, I checked, and that's not the intent of the current code. Tagging previous loans on the "results for grouped record" view would be a wishlist item.

Revision history for this message
Kathy Lussier (klussier) wrote :

That's what I suspected, thanks!

Merged to master and backported to release 2.9 and 2.10.

Thanks Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.