Unique resource name check misses the tenant filter

[Nikita Konovalov]

The resource name check fetches all resource instances from db and does not filter by tenant.

This may cause inability to create cluster with common names like "test" or "demo" in multiple tenants.

The checks should be updated to be tenant specific.

Steps to reproduce issue:

 1. Create PUBLIC node group template 'test' in the project 1.
 2. Switch to the project 2.
 3. Create node group template 'test' in the project 2.
 4. Expected result: node group created. Actual result: NodeGroup template with name 'test' already exists.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/319860

[Vitalii Gridnev (vgridnev)]

It's not optimistic that it will be fixed in newton2

[Vitalii Gridnev (vgridnev)]

Added steps to reproduce issue.

[Telles Mota Vidal Nóbrega (tellesmvn)]

I believe you missed one step:

1.5 - Setting node group template to public

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/404175

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikita Konovalov (<email address hidden>) on branch: master
Review: https://review.openstack.org/319860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/404175
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=b9fecf9657ec018c6b551cd65382c6d3720aa13c
Submitter: Jenkins
Branch: master

commit b9fecf9657ec018c6b551cd65382c6d3720aa13c
Author: Telles Nobrega <email address hidden>
Date: Mon Dec 5 16:50:36 2016 -0300

    Adding tenant_id to regex_search

    In order to allow the creation of clusters with the same across
    projects, even when set to public, we need to filter only cluster from
    the requester's project when creating a new cluster. This will narrow
    the name check to same project only.

    Change-Id: Idd43833c71ef486cf72ebe88ff9df495fff6b809
    Partial-bug: #1584680

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413219
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=e481549c1d9cee56e7b2dfe9f16bfca586c949e7
Submitter: Jenkins
Branch: master

commit e481549c1d9cee56e7b2dfe9f16bfca586c949e7
Author: Telles Nobrega <email address hidden>
Date: Tue Dec 20 16:48:41 2016 -0300

    Adding tenant_id to regex_search

    In order to allow the creation of clusters templates and node group
    templates with the same across projects, even when set to public, we need to
    filter only from the requester's project when creating a new resources.
    This will narrow the name check to same project only.

    Change-Id: Icc39c7e680c2fff583069a5522b2a11afb3e239b
    Closes-bug: #1584680

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/sahara 6.0.0.0b3 development milestone.