Banshee crashes when file/directory is not present

[LCID Fire]

Binary package hint: banshee

When banshee screws up the import there are chances that the underlying file and directory is not present. When doing a Delete from drive it crashes big time. Please patch the following changes into PlayerInterface.cs:

     private void DeleteSong(TrackInfo ti)
        {
  try
  {
            File.Delete(ti.Uri.LocalPath);
  }
  catch(System.IO.DirectoryNotFoundException)
  {
   //directory is not there so for some reason the file is
   //already purged - ignore
  }

[Pepijn van de Geer (pvandegeer)]

This seems to be fixed as the current code of the stable branch looks like this:

        private void DeleteSong(TrackInfo ti)
        {
            File.Delete(ti.Uri.LocalPath);

            // trim empty parent directories
            try {
                string old_dir = Path.GetDirectoryName(ti.Uri.LocalPath);
                while(old_dir != null && old_dir != String.Empty) {
                    Directory.Delete(old_dir);
                    old_dir = Path.GetDirectoryName(old_dir);
                }
            } catch(Exception) {}
        }

[LCID Fire (lcid-fire)]

No, the problem is the File.Delete - not the Directory.Delete

[Andrew Conkling (andrewski)]

Can you test in the new Banshee? It is available on Intrepid, and on Hardy via the Banshee PPA: https://launchpad.net/~banshee-team/+archive.

[Jonathan Thomas (echidnaman)]

We are closing this bug report because it lacks the information we need to investigate the problem, as described in the previous comments. Please reopen it if you can give us the missing information, and don't hesitate to submit bug reports in the future. To reopen the bug report you can click on the current status, under the Status column, and change the Status back to "New". Thanks again!

[Andrew Conkling (andrewski)]

Reopening bug. If this is an issue, it still is, but we should test.

LCID Fire, can you provide some steps to reproduce? I simply don't know what you're referring to in this bug.

[LCID Fire (lcid-fire)]

It is fixed with 1.2 - just tried it in Intrepid.