Wrong handling of errors updating share type extra specs

[Valeriy Ponomaryov]

Admin tab / shares / share types / update

If we try set some unexpected wrong value then we expect error message. But now we get unhandled exception:

Internal Server Error: /admin/shares/update_type/32f9e5c5-ced8-4e32-808a-d58bd1ab67cb/extra_specs
Traceback (most recent call last):
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 164, in get_response
    response = response.render()
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/response.py", line 158, in render
    self.content = self.rendered_content
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/response.py", line 135, in rendered_content
    content = template.render(context, self._request)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/backends/django.py", line 74, in render
    return self.template.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 210, in render
    return self._render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 135, in render
    return compiled_parent._render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 135, in render
    return compiled_parent._render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 202, in _render
    return self.nodelist.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 65, in render
    result = block.nodelist.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 65, in render
    result = block.nodelist.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/defaulttags.py", line 507, in render
    six.reraise(*exc_info)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/template/defaulttags.py", line 493, in render
    url = reverse(view_name, args=args, kwargs=kwargs, current_app=current_app)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 578, in reverse
    return force_text(iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs)))
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 495, in _reverse_with_prefix
    (lookup_view_s, args, kwargs, len(patterns), patterns))
NoReverseMatch: Reverse for 'update_type' with arguments '('',)' and keyword arguments '{}' not found. 1 pattern(s) tried: [u'admin/shares/update_type/(?P<share_type_id>[^/]+)/extra_specs$']

Lookd like it is true for all forms where we have error handling.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/338504
Reason: This one is almost a year now without activity; feel free to restore and resume work on it.

[Jason Grosso (jgrosso)]

Valeriy is still happening in the manila-ui?

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Victoria Martinez de la Cruz <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila-ui/+/338504
Reason: Current code adds the required fields, will check if the related bug report is still valid