netconfig.pp is broken for envs without controllers

[Aleksandr Didenko]

On envs without controllers or VIPs deployment fails on netconfig task with the following error:

2016-05-19 21:46:43 +0000 Puppet (err): invalid address at /etc/puppet/modules/osnailyfacter/manifests/netconfig/netconfig.pp:20 on node node-1.domain.local

Steps to reproduce:

1. Deploy env without controllers or without VIPs

Expected result:
netconfig task executed OK

Actual result:
netconfig task fails

Affected version:
9.0+ (bug introduced by https://review.openstack.org/299294 patch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/319079

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/319079
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=0d009b7facea66a1b88c9a428c8d4250e4790bba
Submitter: Jenkins
Branch: master

commit 0d009b7facea66a1b88c9a428c8d4250e4790bba
Author: Aleksandr Didenko <email address hidden>
Date: Fri May 20 08:39:54 2016 +0200

    Fix netconfig for envs without controllers/vips

    Don't invoke configure_default_route() function if
    management_vrouter_vip is not a valid IP address

    Change-Id: I093f346abd08eb7fe698dcbdf656d8917adb9df2
    Closes-bug: #1583912

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319283

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/320530

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/319283
Reason: it's being reverted

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320530
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=08b7a0b50aa654696fade182f10808354452b778
Submitter: Jenkins
Branch: master

commit 08b7a0b50aa654696fade182f10808354452b778
Author: Aleksandr Didenko <email address hidden>
Date: Tue May 24 15:19:15 2016 +0200

    Revert all network idempotency related fixes

    Revert "Fix netconfig for envs without controllers/vips"
    This reverts commit 0d009b7facea66a1b88c9a428c8d4250e4790bba.

    Revert "Fix netconfig task loop for multiroles"
    This reverts commit 7c106ae13ee38bb5ad91f30ef3a7d58e7c8c2227.

    Revert "Make network configuration idempotent"
    This reverts commit 7903d3d152503da746d2610bb54a4ab5e57ad6bf.

    Change-Id: I3bfd3f31f53fa7fa99414bea956802371de41340
    Closes-bug: #1583912
    Closes-bug: #1583629
    Closes-bug: #1584002

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320807
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f5879c940f584f9f94e6fac7fc95b43c06d4a3ab
Submitter: Jenkins
Branch: stable/mitaka

commit f5879c940f584f9f94e6fac7fc95b43c06d4a3ab
Author: Aleksandr Didenko <email address hidden>
Date: Wed May 25 09:13:19 2016 +0200

    Revert all network idempotency related fixes

    Revert "Fix netconfig task loop for multiroles"
    This reverts commit d850ed5808a783fc6cb447ea2144fb4798ddd75d.

    Revert "Make network configuration idempotent"
    This reverts commit fdb541f57de7d8769441ce92c2526807d5694017.

    Change-Id: I472341efdd2e38cc355d64a46030ffcf17dfac96
    Closes-bug: #1583912
    Closes-bug: #1583629
    Closes-bug: #1584002

[Mikhail Samoylov (msamoylov)]

Passed on ISO 402

[JohnsonYi (yichengli)]

Same issue on fuel 8.0, add new node group and delete it, that cause the vip ip for b_vrouter changed. and ntp update can't work during new node deployment.

any plan for fuel 8.0?

[Aleksandr Didenko (adidenko)]

It does not looks like this bug is the reason since this particular bug was introduced by a patch in 9.0 that was reverted. JohnsonYi, could you please file a new bug with step-by-step instructions how to reproduce?