RunnerSuite.TestOneWorkerStartWhenStopping timed out

[Curtis Hovey]

As seen in
    http://reports.vapour.ws/releases/issue/573e1886749a56605000b574
The RunnerSuite.TestOneWorkerStartWhenStopping test fails when run under race conditions

runner_test.go:147:
    starter.assertStarted(c, true)
runner_test.go:351:
    c.Fatalf("timed out waiting for start notification")
... Error: timed out waiting for start notification

[William Reade (fwereade)]

Ha, found the other race now: just because the *worker* knows it's been started doesn't mean the *runner* knows that yet, which means that we need synchronisation between lines 136-137:

    starter.assertStarted(c, true)
    err = runner.StopWorker("id")

...lest the stop be ignored because "nothing is started", and the rest of the test continue to run against an unexpected state. Trying to think of something more reliable than a voodoo sleep.

[William Reade (fwereade)]

http://reviews.vapour.ws/r/5394/ submitted