Style: Default Theme: Should Support Dropup Menus

Bug #1583754 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Diana Whitten

Bug Description

Bootstrap supports dropup menus in addition to dropdown menus, seen here: http://getbootstrap.com/components/#dropdowns

Right now, our little dropdown arrow only works for drop'down' menus.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/318932

Changed in horizon:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/318932
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2679c3864a2520e312c9be9113a5b2ecf13a839f
Submitter: Jenkins
Branch: master

commit 2679c3864a2520e312c9be9113a5b2ecf13a839f
Author: Diana Whitten <email address hidden>
Date: Thu May 19 12:10:22 2016 -0700

    Default theme lacks support for dropup menus

    The default theme assumes ALL dropdowns are drop'down' menus, however
    Bootstrap supports dropup menus as well. This simplies the logic in
    the theme's dropdown.scss file in order to support all Bootstrap
    types.

    Also, added the dropup to the theme preview page for ease of testing.

    Closes-bug: #1583754
    Change-Id: Ib05bc59c35371dc8b2291d4a0522cf4c52047813

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.