Puppet errror database_hiera_override.pp: Wrong number of arguments given 2 for 1

[Maksym Strukov]

Scenario:
        1. Create cluster
        2. Add 3 nodes with controller role
        3. Add 3 nodes with database, keystone, rabbit,
           horizon
        4. Add 1 compute and cinder
        5. Verify networks
        6. Deploy the cluster

Actual:
Task 'deploy' has incorrect status. error != ready, 'Deployment has failed. All nodes are finished. Failed tasks: Task[keystone-hiera-override/1], Task[database-hiera-override/1], Task[keystone-hiera-override/3], Task[database-hiera-override/3], Task[keystone-hiera-override/2], Task[database-hiera-override/2], Task[database-hiera-override/5], Task[keystone-hiera-override/5], Task[database-hiera-override/4], Task[keystone-hiera-override/4], Task[database-hiera-override/6], Task[keystone-hiera-override/6], Task[database-hiera-override/9], Task[keystone-hiera-override/9], Task[database-hiera-override/8], Task[keystone-hiera-override/8] Stopping the deployment process!'

puppet-apply log contain:
2016-05-19T01:47:13.534497+00:00 notice: (Scope(Class[main])) MODULAR: detach-database/database_hiera_override.pp
2016-05-19T01:47:13.693372+00:00 err: parseyaml(): Wrong number of arguments given 2 for 1 at /etc/fuel/plugins/detach-database-1.1/database_hiera_override.pp:14 on node node-1.test.domain.local
2016-05-19T01:47:13.693372+00:00 err: /etc/puppet/modules/stdlib/lib/puppet/parser/functions/parseyaml.rb:13:in `block in <module:Functions>'
2016-05-19T01:47:13.693397+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/functions.rb:164:in `block (2 levels) in newfunction'
2016-05-19T01:47:13.693397+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler/around_profiler.rb:58:in `profile'
2016-05-19T01:47:13.693404+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:51:in `profile'
2016-05-19T01:47:13.693404+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/functions.rb:157:in `block in newfunction'
2016-05-19T01:47:13.693411+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/function.rb:42:in `evaluate'
2016-05-19T01:47:13.693411+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:61:in `safeevaluate'
2016-05-19T01:47:13.693417+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/vardef.rb:14:in `evaluate'
2016-05-19T01:47:13.693417+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:61:in `safeevaluate'
2016-05-19T01:47:13.693422+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:11:in `block in evaluate'
2016-05-19T01:47:13.693422+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `each'
2016-05-19T01:47:13.693428+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `evaluate'
2016-05-19T01:47:13.693428+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:61:in `safeevaluate'
2016-05-19T01:47:13.693433+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/ifstatement.rb:25:in `evaluate'
2016-05-19T01:47:13.693433+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:61:in `safeevaluate'
2016-05-19T01:47:13.693439+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:11:in `block in evaluate'
2016-05-19T01:47:13.693439+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `each'
2016-05-19T01:47:13.693445+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `evaluate'
2016-05-19T01:47:13.693445+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:61:in `safeevaluate'
2016-05-19T01:47:13.693450+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/resource/type.rb:129:in `evaluate_code'
2016-05-19T01:47:13.693450+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/resource.rb:81:in `block in evaluate'
2016-05-19T01:47:13.693455+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler/around_profiler.rb:58:in `profile'
2016-05-19T01:47:13.693455+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:51:in `profile'
2016-05-19T01:47:13.693460+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/resource.rb:77:in `evaluate'
2016-05-19T01:47:13.693460+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:426:in `evaluate_main'
2016-05-19T01:47:13.693465+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:135:in `block (2 levels) in compile'
2016-05-19T01:47:13.693465+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler/around_profiler.rb:58:in `profile'
2016-05-19T01:47:13.693470+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:51:in `profile'
2016-05-19T01:47:13.693470+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:135:in `block in compile'
2016-05-19T01:47:13.693475+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/context.rb:64:in `override'
2016-05-19T01:47:13.693475+00:00 err: /usr/lib/ruby/vendor_ruby/puppet.rb:246:in `override'
2016-05-19T01:47:13.693480+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:121:in `compile'
2016-05-19T01:47:13.693480+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:34:in `compile'
2016-05-19T01:47:13.693484+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:95:in `block (2 levels) in compile'
2016-05-19T01:47:13.693484+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler/around_profiler.rb:58:in `profile'
2016-05-19T01:47:13.693489+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:51:in `profile'
2016-05-19T01:47:13.693489+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:93:in `block in compile'
2016-05-19T01:47:13.693494+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util.rb:161:in `block in benchmark'
2016-05-19T01:47:13.693494+00:00 err: /usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
2016-05-19T01:47:13.693498+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util.rb:160:in `benchmark'
2016-05-19T01:47:13.693498+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:92:in `compile'
2016-05-19T01:47:13.693503+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:52:in `find'
2016-05-19T01:47:13.693503+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/indirector/indirection.rb:201:in `find'
2016-05-19T01:47:13.693508+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:222:in `block in main'
2016-05-19T01:47:13.693508+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/context.rb:64:in `override'
2016-05-19T01:47:13.693513+00:00 err: /usr/lib/ruby/vendor_ruby/puppet.rb:246:in `override'
2016-05-19T01:47:13.693513+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:198:in `main'
2016-05-19T01:47:13.693518+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:159:in `run_command'
2016-05-19T01:47:13.693518+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block (2 levels) in run'
2016-05-19T01:47:13.693523+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application.rb:507:in `plugin_hook'
2016-05-19T01:47:13.693523+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block in run'
2016-05-19T01:47:13.693527+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util.rb:496:in `exit_on_fail'
2016-05-19T01:47:13.693527+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `run'
2016-05-19T01:47:13.693532+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:146:in `run'
2016-05-19T01:47:13.693532+00:00 err: /usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:92:in `execute'
2016-05-19T01:47:13.693536+00:00 err: /usr/bin/puppet:8:in `<main>'

Env: 9.0 mos iso #372
* https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.thread_2_separate_services/112/testReport/(root)/separate_all_service/separate_all_service/
* https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.thread_keystone_separate_services/111/testReport/(root)/separate_keystone_service/separate_keystone_service/
* https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.thread_2_separate_services/112/testReport/(root)/separate_all_service/separate_all_service/

[Matthew Mosesohn (raytrac3r)]

Maksym, I will make a stable/mitaka branch for 9.0 tests. These are failing because we updated stdlib for master, but 9.0 is still running an older version. I had to update the logic for the new parseyaml behavior, but it's not backward compatible.

[Matthew Mosesohn (raytrac3r)]

QA team, please update 9.0 swarm jobs to use plugins built from branch stable/mitaka instead of master.

[Nastya Urlapova (aurlapova)]

Ci-folks, please switch our detached plugins on stable/mitaka branch, it can be done in review https://review.fuel-infra.org/#/c/19833/

[Aleksandra Fedorova (bookwar)]

Depends on https://bugs.launchpad.net/fuel/+bug/1584123

[Lesya Novaselskaya (onovaselskaya)]

^^^ https://bugs.launchpad.net/fuel/+bug/1584123 is worked around, so it does not block this one at the moment. Plugins built successfully: https://product-ci.infra.mirantis.net/job/build-fuel-plugins/9/

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: master
Change author: Lesya Novaselskaya <email address hidden>
Review: https://review.fuel-infra.org/21133

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21133
Submitter: Lesya Novaselskaya <email address hidden>
Branch: master

Commit: 89417efa6db4dd2bb2c9da3a2cde37cd537abc68
Author: Lesya Novaselskaya <email address hidden>
Date: Mon May 23 14:32:43 2016

Use plugins built in 'stable/mitaka' for 9.0 swarm

Stdlib was updated for master recently, but an older version still
remains in 9.0. Since it lacks backward compatibility, plugins are
to be built from 'stable/mitaka' branch to fit.

Closes-bug: #1583446

Change-Id: I3be45f91d1e7014fe27e4c57992020580cba9dcf
Signed-off-by: Lesya Novaselskaya <email address hidden>

[Lesya Novaselskaya (onovaselskaya)]

https://review.fuel-infra.org/#/c/21133 <--- merged
As long as it's UTC time, plugins will start at 19 to be completed before all the swarm starts (just in case)