[fuel-octane] a network template should be validated before upgrade process is started

Bug #1583063 reported by Pavel Chechetin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Oleg S. Gelbukh

Bug Description

Detailed bug description:
 Octane doesn't validate provided network template.

Steps to reproduce:
 Make sure ~/network_template_xxx.yaml doesn't exist
 octane --debug -v upgrade-node --template ~/network_template_xxx.yaml --isolated 2 1

Actual result:
 Octane starts an upgrade process and fails when the network template is actually needed

Expected results:
 Octane should validate provided network template for:
  * Readability
  * Is valid YAML file

Reproducibility:
 Always

tags: added: team-upgrades
description: updated
description: updated
description: updated
description: updated
Dmitry Klenov (dklenov)
Changed in fuel:
milestone: none → 10.0
assignee: nobody → Fuel Octane (fuel-octane-team)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/322973

Changed in fuel:
assignee: Fuel Octane (fuel-octane-team) → Oleg S. Gelbukh (gelbuhos)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/325892

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/325892
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=86a7e912a3efe00dc686014d17060ab001638b8a
Submitter: Jenkins
Branch: master

commit 86a7e912a3efe00dc686014d17060ab001638b8a
Author: Oleg Gelbukh <email address hidden>
Date: Mon Jun 6 12:58:15 2016 +0000

    Add function for checking sanity of nodes to upgrade

    Move sanity checks logic for upgrading node into separate
    function.

    Change-Id: Ifa46753f0bed18a0e25887c2a07445145011dad4
    Related-bug: 1583063

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/322973
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=58b294c8c36da9398940c15a692283212da35861
Submitter: Jenkins
Branch: master

commit 58b294c8c36da9398940c15a692283212da35861
Author: Oleg Gelbukh <email address hidden>
Date: Mon May 30 19:43:02 2016 +0000

    Verify network template sanity before loading

    Open file with network template and load it as YaML. Fail, log
    and raise exception if any error occurs opening the file.

    Change-Id: Ie516749c832c23bb739ebb5d02dd9bd5a9807b7f
    Closes-bug: 1583063

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/332821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/332822

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/332821
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=b3dcb0e448bdfa95f4c46ca3180ebb1c4253d802
Submitter: Jenkins
Branch: stable/8.0

commit b3dcb0e448bdfa95f4c46ca3180ebb1c4253d802
Author: Oleg Gelbukh <email address hidden>
Date: Mon Jun 6 12:58:15 2016 +0000

    Add function for checking sanity of nodes to upgrade

    Move sanity checks logic for upgrading node into separate
    function.

    Change-Id: Ifa46753f0bed18a0e25887c2a07445145011dad4
    Related-bug: 1583063
    (cherry picked from commit 86a7e912a3efe00dc686014d17060ab001638b8a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/332822
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=c6cce6295f85b77a9f101d8f800a468b065d45a2
Submitter: Jenkins
Branch: stable/8.0

commit c6cce6295f85b77a9f101d8f800a468b065d45a2
Author: Oleg Gelbukh <email address hidden>
Date: Mon May 30 19:43:02 2016 +0000

    Verify network template sanity before loading

    Open file with network template and load it as YaML. Fail, log
    and raise exception if any error occurs opening the file.

    Change-Id: Ie516749c832c23bb739ebb5d02dd9bd5a9807b7f
    Closes-bug: 1583063
    (cherry picked from commit 58b294c8c36da9398940c15a692283212da35861)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.