[fuel-library] deployment failed with "Cannot evaluate expression" deleted_nodes

[Sergey Kulanov]

Detailed bug description:

 Deployment failed with error

2016-05-13 09:47:18.003 ERROR [7f4bbf394880] (__init__) Cannot evaluate expression - '{"deleted_nodes" => deleted($.nodes.fqdn)}.toYaml()' (None), : u'nodes'
2016-05-13 09:47:18.004 ERROR [7f4bbf394880] (transaction_serializer) Failed to serialize task generate_deleted_nodes
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nailgun/lcm/transaction_serializer.py", line 140, in process_task
    task = task_serializer.serialize(node_id)

full log is here [1]

Steps to reproduce:
 run bvt, smoke tests
Expected results:
 Successful deployment
Actual result:
 Deployment failed
Reproducibility:
 each time
Workaround:

   * probably we have a regression introduced by this patchset [2], so propose to check and revert if needed

Impact:
 SWARM blocker
Description of the environment:

Additional information:
  * we also need to check 9.0 since this patch was backported

[1]. http://paste.openstack.org/show/497021/
[2]. https://review.openstack.org/#/c/309319/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316000

[Michael Polenchuk (mpolenchuk)]

Quick fix instead of revert:
$.network_metadata.nodes.values().fqdn

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316009

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316017

[Matthew Mosesohn (raytrac3r)]

The root cause here is that the "nodes" hash in serialized data was removed around the same time as this patch was merged. The CI ISO was dated and still contained it. Michael Polenchuk has a patch on review to get deleted node FQDNs via network_metadata hash

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316009
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4079e6d0ec76cdd2eb51477e2f23a5c2bf220776
Submitter: Jenkins
Branch: master

commit 4079e6d0ec76cdd2eb51477e2f23a5c2bf220776
Author: Michael Polenchuk <email address hidden>
Date: Fri May 13 13:21:25 2016 +0300

    Mend deleted_nodes task(s)

    Change yaql expr to trigger only if delete event is occur.
    Get fqdn data from network_metadata source as well.

    Change-Id: I35081ae57502905382045953cba16dd39c39d585
    Closes-Bug: #1581436

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/316000

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/316017