There is no Deploy Changes button for Partially deployed cluster after stopped deployment

[Alexey Shtokolov]

Version: Fuel 9.0 build 285

Steps to reproduce:
 Create cluster
 Add nodes
 Provision all nodes using Provisioning Only mode
 Run Deployment for all nodes via Deployment Only mode
 Stop Deployment via CLI
 Try to redeploy

Expected results:
 Deploy Changes button on Dashboard Tab

Actual result:
 Cluster is in partially_deployed state but there is no Deploy Changes button on Dashboard Tab

[Julia Aranovich (jkirnosova)]

There are conditions of Deploy Changes button visibility:
https://github.com/openstack/fuel-ui/blob/stable/mitaka/static/models.js#L368-L372

If the cluster has 'partially_deployed' status, then we should check it's release availability or we need to be sure there is no running deployment task.

Can not reproduce the issue on dev environment (fake Nailgun): http://s32.postimg.org/ebia5y22t/Screenshot_from_2016_05_13_10_07_41.png

Alexey, could you please provide screenshots of the cluster Dashboard and Nodes tabs after stopping of nodes deployment? An ability to research the live environment would be great.

[Julia Aranovich (jkirnosova)]

The issue was investigated. There is no check of environment status here: https://github.com/openstack/fuel-ui/blob/stable/mitaka/static/views/cluster_page_tabs/dashboard_tab.js#L780-L784

Alexey, thank you for providing of live environment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316065

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316722

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316065
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=7cfd0c80bda3fe22c18745b7a9de6c371510df13
Submitter: Jenkins
Branch: master

commit 7cfd0c80bda3fe22c18745b7a9de6c371510df13
Author: Julia Aranovich <email address hidden>
Date: Fri May 13 15:37:14 2016 +0300

    Fix render of cluster actions panel

    It should be possible to deploy an environment with all nodes in 'ready' status,
    if the environment is not operational.

    Closes-Bug: #1581237

    Change-Id: Id40ebaaf0b27d749688b7a9dfaf13450cd7f58e9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316722
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c0de7f1f2e02a0ba8c48c443bb4fbc5600dfa7e5
Submitter: Jenkins
Branch: stable/mitaka

commit c0de7f1f2e02a0ba8c48c443bb4fbc5600dfa7e5
Author: Julia Aranovich <email address hidden>
Date: Fri May 13 15:37:14 2016 +0300

    Fix render of cluster actions panel

    It should be possible to deploy an environment with all nodes in 'ready' status,
    if the environment is not operational.

    Closes-Bug: #1581237

    Change-Id: Id40ebaaf0b27d749688b7a9dfaf13450cd7f58e9

[Mikhail Samoylov (msamoylov)]

Passed on ISO 402