add_openstack_reserverd_ports in pre_check

[Nagendra Prasath]

pre_check task called during setup_all/setup_without_openstack seems to be validating basic sanity on configurations but not sure why “add_openstack_reserverd_ports” was added to it? add_openstack_reserverd_ports looks more of a configuration rather than a check.

If thats as expected, i’d write precheck_without_openstack.. let me know.
If thats not expected, i can move add_openstack_reserverd_ports to setup_all task itself.

Also
setup_openstack also calls add_openstack_reserved_ports which makes me think to remove add_openstack_reserved_ports from pre_check. But want to know if there is a reason why it was added to pre_check.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20766
Submitter: Nagendra Prasath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20767
Submitter: Nagendra Prasath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20766
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/0115cdb1655f8c282a7e07057097494f9c981b2f
Submitter: Zuul
Branch: R3.0

commit 0115cdb1655f8c282a7e07057097494f9c981b2f
Author: Nagendra Chandran <email address hidden>
Date: Mon May 30 13:59:05 2016 -0700

1. Removing add_openstack_reserverd_ports from pre_check and include during install_openstack as its more appropriate
2. pre_check looks for internal vip when more than one openstack is defined and its not applicable when using external openstack

Change-Id: Idab13df59f6348fef43651d0d91a61fd28cb8dc6
Closes-Bug: 1581071
Closes-Bug: 1581544

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20767
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/c036fd82f3f3364c7c974180e66d44e8e42433ff
Submitter: Zuul
Branch: master

commit c036fd82f3f3364c7c974180e66d44e8e42433ff
Author: Nagendra Chandran <email address hidden>
Date: Mon May 30 14:03:59 2016 -0700

1. Removing add_openstack_reserverd_ports from pre_check and include during install_openstack as its more appropriate
2. pre_check looks for internal vip when more than one openstack is defined and its not applicable when using external openstack

Change-Id: Ieee0057b57f3a162226a3a9e3f1a0c65c6bcb03c
Closes-Bug: 1581071
Closes-Bug: 1581544