Fuel for OpenStack

Get last successful transaction per task does not evaluate status of deployment tasks per node

Bug #1581015 reported by Vladimir Kuklin
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Nikita Zubkov
Fuel for OpenStack 10.0
Mitaka
Fix Released
High
Nikita Zubkov
Fuel for OpenStack 9.0

Bug Description

With https://review.openstack.org/#/c/310019 we do not search properly for the latest successful execution of a particular task as we do not filter per node. This would lead to false-positive choice of previous deployment transaction and issues with smart YAQL-based redeployment

Tags: area-python
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317614

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Nikita Zubkov (zubchick) wrote :

ETA: 25.05.2016

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/317614
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5ba7416156786e6d409c6f3a969441b55c2ea2bb
Submitter: Jenkins
Branch: master

commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

    Fix getting previous state for deployment

    Now we get last success transaction not only for every task but for
    every node in the cluster. The previous version of state collecting
    function may lead to false-positive choice of previous deployment
    transaction and issues with smart YAQL-based redeployment.

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320329

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/320329
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=48cb2465e0e04b8a6fb03b740560be929dd2a75f
Submitter: Jenkins
Branch: stable/mitaka

commit 48cb2465e0e04b8a6fb03b740560be929dd2a75f
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

    Fix getting previous state for deployment

    Now we get last success transaction not only for every task but for
    every node in the cluster. The previous version of state collecting
    function may lead to false-positive choice of previous deployment
    transaction and issues with smart YAQL-based redeployment.

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269
    (cherry picked from commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb)

Alisa Tselovalnikova (atselovalnikova)
tags: added: on-verification
Revision history for this message
Alisa Tselovalnikova (atselovalnikova) wrote :

Verified on http://paste.openstack.org/show/516793.

Verification steps:
    1. Create cluster.
    2. Add 1 node with controller role.
    3. Deploy node.
    4. Add 1 node with compute role.
    5. Deploy node.

All steps are passed.

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.