hz-expand-detail cannot be used outside of hz-table

[Tyr Johanson]

hz-expand-detail is a reasonably handy directive that allows row expansion. It was modified to allow a table user to detect row expansion. However, this modification added a require of the hz-table controller.

This is not necessary, is difficult to maintain and prevents the reuse of this with anything other than hz-table.

Instead, the directive should simply emit an event and any parent that cares can listen for it.

[Tyr Johanson (tyr-6)]

Here is the change that attempted to improve hz-expand-detail

https://review.openstack.org/#/c/287473/

Notice how it requires the hzCtrl so that it can call a function? This is very problematic, instead it should simple emit an event that hz-table listens for, if it cares.

To do it well, we might consider modifying the table define a standard set of events that it listens to from its children, and standard events its children can listen for.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/321089

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321089
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fe98059ca108d80b412e73ec373904c310795b37
Submitter: Jenkins
Branch: master

commit fe98059ca108d80b412e73ec373904c310795b37
Author: Tyr Johanson <email address hidden>
Date: Wed May 25 09:49:06 2016 -0600

    Relax hz-table parent requirement

    hz-expand-detail is a pretty handy directive to use in normal
    HTML tables. This patch changes the parent directive requirement
    to be optional.

    Change-Id: Ic0b0c7af6143ec1d654cb277503342693d051b50
    Closes-Bug: #1580809

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.