Metadata display widget should use case insensitive matching

Bug #1580790 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Travis Tripp

Bug Description

The metadata-display should match properties using case insensitive. I've found that if you pass in extra metadata properties to Glance v1 at create time, it takes all the properties and stores them as lower case. So when you create an image with metadata of FOO=BAR, it will store as foo=bar.

Maybe when we move off to v2 Glance that won't be a problem?

There are some properties "CIM_PASD_InstructionSet" that when created at the same time as creating the image get changed to cim_pasd_instructionset". When this gets subsequently retrieved from Glance and displayed in the metadata-display widget, it doesn't recognize them and won't show them.

See:

https://review.openstack.org/#/c/236042/

https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/glance.py#L189-L190

Changed in horizon:
assignee: nobody → Travis Tripp (travis-tripp)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/315295

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/315295
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=802ec1f77a2c4aa40804d2f1e46cdc28a757f6d6
Submitter: Jenkins
Branch: master

commit 802ec1f77a2c4aa40804d2f1e46cdc28a757f6d6
Author: Travis Tripp <email address hidden>
Date: Wed May 11 18:06:27 2016 -0600

    Change Metadata Display widget to case insensitive

    The metadata-display should match properties using case insensitive.
    I've found that if you pass in extra metadata properties to
    Glance v1 at create time, it takes all the properties and stores
    them as lower case. So when you create an image with metadata of
    FOO=BAR, it will store as foo=bar.

    There are some properties "CIM_PASD_InstructionSet" that when
    create at the same time as creating the image get changed to
    cim_pasd_instructionset". When this gets subsequently retrieved
    from Glance and displayed in the metadata-display widget,
    it doesn't recognize them and won't show them.

    To test, you need: https://review.openstack.org/#/c/236042/

    Create an Image using the CIM Instruction Set metadata.

    Go to image row and expand. You won't see the metadata.

    Apply this patch git review -x 315295

    Then do the same steps. You'll see the metadata displayed:

    http://imgur.com/eMfLd9H

    Change-Id: I5127283e90505f3580af6afea3eb992a91b8dfc8
    Closes-Bug: 1580790

Changed in horizon:
status: In Progress → Fix Released
tags: added: mitaka-backport-poential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/318357

Changed in horizon:
importance: Undecided → Medium
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/318357
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cdde60c315335c74eda9e0d7eb809da10a73855c
Submitter: Jenkins
Branch: stable/mitaka

commit cdde60c315335c74eda9e0d7eb809da10a73855c
Author: Travis Tripp <email address hidden>
Date: Wed May 11 18:06:27 2016 -0600

    Change Metadata Display widget to case insensitive

    The metadata-display should match properties using case insensitive.
    I've found that if you pass in extra metadata properties to
    Glance v1 at create time, it takes all the properties and stores
    them as lower case. So when you create an image with metadata of
    FOO=BAR, it will store as foo=bar.

    There are some properties "CIM_PASD_InstructionSet" that when
    create at the same time as creating the image get changed to
    cim_pasd_instructionset". When this gets subsequently retrieved
    from Glance and displayed in the metadata-display widget,
    it doesn't recognize them and won't show them.

    To test, you need: https://review.openstack.org/#/c/236042/

    Create an Image using the CIM Instruction Set metadata.

    Go to image row and expand. You won't see the metadata.

    Apply this patch git review -x 315295

    Then do the same steps. You'll see the metadata displayed:

    http://imgur.com/eMfLd9H

    Change-Id: I5127283e90505f3580af6afea3eb992a91b8dfc8
    Closes-Bug: 1580790
    (cherry picked from commit 802ec1f77a2c4aa40804d2f1e46cdc28a757f6d6)

tags: added: in-stable-mitaka
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 9.0.1

This issue was fixed in the openstack/horizon 9.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.