[puppet-pacemaker] Change of primitive type from 'simple' to 'clone' is not working

[Nikita Karpin]

Detailed bug description:
 When deploying environment with fuel ceilometer redis plugin on MOS 9.0 (using this patch https://review.openstack.org/#/c/311132/5) deployment is failing with the next error:

2016-05-05 09:27:41 +0000 /Stage[main]/Redis::Main/Pacemaker::Service[ceilometer-agent-central]/Pcmk_resource[p_ceilometer-agent-central]/complex_type (notice): complex_type changed '' to 'clone'
2016-05-05 10:00:52 +0000 /Stage[main]/Redis::Main/Pacemaker::Service[ceilometer-agent-central]/Pcmk_resource[p_ceilometer-agent-central] (err): Could not evaluate: Execution timeout after 1800 seconds!
/usr/lib/ruby/vendor_ruby/puppet/util/errors.rb:106:in `fail'
/etc/puppet/modules/pacemaker/lib/puppet/pacemaker/wait.rb:25:in `retry_block'
/etc/puppet/modules/pacemaker/lib/puppet/pacemaker/wait.rb:133:in `wait_for_primitive_remove'
/etc/puppet/modules/pacemaker/lib/puppet/provider/pcmk_resource/xml.rb:176:in `remove_primitive'
/etc/puppet/modules/pacemaker/lib/puppet/provider/pcmk_resource/xml.rb:286:in `flush'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:990:in `flush'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:24:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:204:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:217:in `eval_resource'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:147:in `call'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:147:in `block (2 levels) in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:335:in `block in thinmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:334:in `thinmark'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:147:in `block in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:118:in `traverse'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:138:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:169:in `block in apply'
/usr/lib/ruby/vendor_ruby/puppet/util/log.rb:149:in `with_destination'
/usr/lib/ruby/vendor_ruby/puppet/transaction/report.rb:112:in `as_logging_destination'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:168:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:120:in `block in apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:161:in `block in benchmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:160:in `benchmark'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:119:in `apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:227:in `run_internal'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:134:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/context.rb:64:in `override'
/usr/lib/ruby/vendor_ruby/puppet.rb:246:in `override'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:133:in `run'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:302:in `apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:236:in `block in main'
/usr/lib/ruby/vendor_ruby/puppet/context.rb:64:in `override'
/usr/lib/ruby/vendor_ruby/puppet.rb:246:in `override'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:198:in `main'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:159:in `run_command'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:507:in `plugin_hook'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:496:in `exit_on_fail'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:146:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:92:in `execute'
/usr/bin/puppet:8:in `<main>'

Pacemaker.log has next errors:

<27>May 10 18:43:27 node-14 cib[6746]: error: IDREF attribute rsc references an unknown ID "p_ceilometer-agent-central"
<27>May 10 18:43:27 node-14 cib[6746]: error: IDREF attribute rsc references an unknown ID "p_ceilometer-agent-central"
<27>May 10 18:43:27 node-14 cib[6746]: error: IDREF attribute rsc references an unknown ID "p_ceilometer-agent-central"

Steps to reproduce:
 1. Install Fuel ceilometer redis plugin with patch https://review.openstack.org/#/c/311132/5
 2. Create environment with 3 controllers and 1 compute node
 3. Choose ceilometer and aodh services and ceilometer redis plugin to be installed
 4. Start deployment
Expected results:
 After deployment p_ceilometer-agent-central primitive has type clone on all 3 controllers in pcs resource show command output
Actual result:
 p_ceilometer-agent-central still has simple type
Reproducibility:
 Reproduced on MOS 9 ISO 260
Workaround:
 -
Impact:
 Environment deployment with Fuel Ceilometer redis plugin is not successful
Description of the environment:
 Operation system: Ubuntu
 Versions of components: MOS 9
Additional information:
 In MOS 8 change of primitive type to clone worked fine with pacemaker_wrappers puppet class, but in MOS 9 this class was refactored and moved to https://github.com/fuel-infra/puppet-pacemaker

[Roman Podoliaka (rpodolyaka)]

Dmitry, please clarify the importance here.

[Roman Podoliaka (rpodolyaka)]

Maybe Medium is a better importance for this issue (as I understand, only one particular plugin is affected).

Team, we trust your best judgement here - please downgrade the importance if needed (set to High in the first place only because we would have to close it as Won't Fix otherwise).

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: master
Change author: Dmitry Ilyin <email address hidden>
Review: https://review.fuel-infra.org/20767

[Ivan Berezovskiy (iberezovskiy)]

This issue reproduces only with one specific plugin (ceilometer-redis plugin). As I know it doesn't affect any other. Workaround for plugin was already implemented (https://review.openstack.org/#/c/311132/). So, I'd prefer to low priority and mark as won't fix for 9.0. We can fix it for 10.0 using upstream puppet-pacemaker module implementation (https://review.openstack.org/#/c/296440/) and we won't need to implement workaround for this.
Please feel free to rise priority if some other plugins are affected and it's critical issue for them.