set_initial_networking_configuration shouldn't raise ValidationError
Bug #1580405 reported by
Lee Trager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The root cause of LP:1580285 was that Node.set_
Related branches
lp:~ltrager/maas/fix_exception
- Andres Rodriguez (community): Approve
- Blake Rouse (community): Approve
-
Diff: 288 lines (+71/-73)6 files modifiedsrc/maasserver/api/devices.py (+1/-1)
src/maasserver/api/machines.py (+14/-1)
src/maasserver/api/tests/test_devices.py (+1/-1)
src/maasserver/api/tests/test_machine.py (+50/-13)
src/maasserver/models/node.py (+3/-20)
src/maasserver/models/tests/test_node.py (+2/-37)
Revision history for this message
| Lee Trager (ltrager) wrote | #1 |
| Changed in maas: | |
| status: | New → Invalid |
| Changed in maas: | |
| status: | Invalid → In Progress |
| summary: |
- Exceptions raised during commissioning not raised + set_initial_networking_configuration shouldn't raise ValidationError |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
After speaking with Blake about this it appears that this was due to me raising a ValidationError. ValidationErrors are meant to be user errors(e.g an invalid option passed over the API) and are thus ignored. Changing the validation to use an assert shows the error.