SM: Modifying cluster by re-adding from json wipes out generated passwords

[Nitish Krishna Kaveri]

issue seen in 3.0.2-35-kilo

1. Cluster was added using json. Passwords were generated.

root@sdkvse9:~/nitishk# server-manager add cluster -f openstack-only-cluster.json
{
    "return_code": 0,
    "return_data": {
        "cluster": [
            {
                "base_image_id": "",
                "email": "",
                "id": "openstack-only-cluster",
                "package_image_id": "",
                "parameters": {
                    "provision": {
                        "contrail": {
                            "database": {
                                "database_minimum_diskGB": 32
                            }
                        },
                        "openstack": {
                            "heat_encryption_key": "73D9EE851916",
                            "keystone": {
                                "admin_password": "210AB1B04A51",
                                "admin_token": "816DCAFADAB2"
                            },
                            "mysql": {
                                "allowed_hosts": [
                                    "localhost",
                                    "127.0.0.1",
                                    "99.1.1.1",
                                    "99.1.1.2",
                                    "99.1.1.5",
                                    "99.1.1.10"
                                ],
                                "root_password": "4922C6EED2EC",
                                "service_password": "AFE1697BEB88"
                            },
                            "nova": {
                                "neutron_ip_to_use": "99.1.1.2"
                            },
                            "openstack_manage_amqp": true,
                            "region": "RegionOne"
                        }
                    },
                    "storage_fsid": "65539895-0b51-47f0-99cb-56d31078cf04",
                    "storage_virsh_uuid": "9ea5679d-e06e-4c6d-a915-12a4f1aac83c",
                    "uuid": "67fa6533-f7e1-4e83-b2dd-36b4d050e926"
                },
                "provision_role_sequence": {
                    "completed": [],
                    "steps": []
                }
            }
        ]
    },
    "return_msg": "Cluster Add/Modify Success"
}

2. Server was modified by re-adding server from json. The generated passwords were wiped out.

root@sdkvse9:~/nitishk# server-manager add cluster -f openstack-only-cluster.json
{
    "return_code": 0,
    "return_data": {
        "cluster": [
            {
                "id": "openstack-only-cluster",
                "parameters": {
                    "provision": {
                        "contrail": {
                            "database": {
                                "database_minimum_diskGB": 32
                            }
                        },
                        "openstack": {
                            "mysql": {
                                "allowed_hosts": [
                                    "localhost",
                                    "127.0.0.1",
                                    "99.1.1.1",
                                    "99.1.1.2",
                                    "99.1.1.5",
                                    "99.1.1.10"
                                ]
                            },
                            "nova": {
                                "neutron_ip_to_use": "99.1.1.2"
                            },
                            "openstack_manage_amqp": true,
                            "region": "RegionOne"
                        }
                    }
                }
            }
        ]
    },
    "return_msg": "Cluster Add/Modify Success"
}

root@sdkvse9:~/nitishk# server-manager show cluster --cluster_id openstack-only-cluster --detail
{
    "cluster": [
        {
            "base_image_id": "",
            "email": "",
            "id": "openstack-only-cluster",
            "package_image_id": "",
            "parameters": {
                "provision": {
                    "contrail": {
                        "database": {
                            "database_minimum_diskGB": 32
                        }
                    },
                    "openstack": {
                        "mysql": {
                            "allowed_hosts": [
                                "localhost",
                                "127.0.0.1",
                                "99.1.1.1",
                                "99.1.1.2",
                                "99.1.1.5",
                                "99.1.1.10"
                            ]
                        },
                        "nova": {
                            "neutron_ip_to_use": "99.1.1.2"
                        },
                        "openstack_manage_amqp": true,
                        "region": "RegionOne"
                    }
                },
                "storage_fsid": "65539895-0b51-47f0-99cb-56d31078cf04",
                "storage_virsh_uuid": "9ea5679d-e06e-4c6d-a915-12a4f1aac83c",
                "uuid": "67fa6533-f7e1-4e83-b2dd-36b4d050e926"
            },
            "provision_role_sequence": "{'completed': [], 'steps': []}",
            "provisioned_id": null
        }
    ]
}