Designate

oslo.messaging 5.0.0 breaks designate

Bug #1580139 reported by Kiall Mac Innes on 2016-05-10

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Barbican	Fix Released	Undecided	Juan Antonio Osorio Robles
Designate	Fix Released	Critical	Kiall Mac Innes	Designate newton-1 "n1"
Mistral	Fix Released	Critical	Renat Akhmerov	Mistral newton-1 "n1"

Bug Description

oslo.messaging v5 changed the RPCDispatcher and RPCServer interfaces.

Any project using these interfaces directly appears to be broken with v5

Traceback (most recent call last):
  File "designate/tests/test_agent/test_backends/test_fake.py", line 27, in setUp
    super(FakeAgentBackendTestCase, self).setUp()
  File "designate/tests/__init__.py", line 377, in setUp
    self.central_service = self.start_service('central')
  File "designate/tests/__init__.py", line 446, in start_service
    fixture = fixtures.ServiceFixture(svc_name, *args, **kw)
  File "designate/tests/fixtures.py", line 76, in __init__
    self.svc = cls()
  File "designate/central/service.py", line 193, in __init__
    super(Service, self).__init__(threads=threads)
  File "designate/service.py", line 149, in __init__
    self._rpc_endpoints)
  File "designate/rpc.py", line 207, in get_server
    dispatcher = RPCDispatcher(target, endpoints, serializer)
TypeError: __init__() takes exactly 3 arguments (4 given)

See original description

Tags:

Revision history for this message

Kiall Mac Innes (kiall) wrote on 2016-05-10:

https://github.com/openstack/oslo.messaging/commit/990d894eaf0d18941b56d89bff2bca51de375640 changes the RPCDispatcher class API.

Revision history for this message

Kiall Mac Innes (kiall) wrote on 2016-05-10:

Related to bug 1412977

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314528

Changed in designate:
assignee:	nobody → Kiall Mac Innes (kiall)
status:	Triaged → In Progress

Revision history for this message

Kiall Mac Innes (kiall) wrote on 2016-05-10:

Looks like this will break mistral too - https://github.com/openstack/mistral/blob/master/mistral/engine/rpc.py#L85

Revision history for this message

Kiall Mac Innes (kiall) wrote on 2016-05-10:

Looks like barbian too http://git.openstack.org/cgit/openstack/barbican/tree/barbican/queue/__init__.py#n110

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix merged to designate (master)

Reviewed: https://review.openstack.org/314528
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=ca7ffbab5b0df9cffa783a1864196c17cfd40b49
Submitter: Jenkins
Branch: master

commit ca7ffbab5b0df9cffa783a1864196c17cfd40b49
Author: Kiall Mac Innes <email address hidden>
Date: Tue May 10 13:06:49 2016 +0100

Support both olso.m v4 and v5

    Oslo.Messaging v5 made some API changes which broke us in
    I5f23e23644e90919cb67f81fc306ee85c5e09974. Update our
    code to "detect" this API change, and behave accordingly.

    Closes-Bug: 1580139
    Partial-Bug: 1412977
    Change-Id: I5b44cd2ded32d90be6efda7b5238df72ce6c6cbd

Changed in designate:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/314608

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix proposed to designate (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314609

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/314608
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=3011dc0d130bfde9b5504bc507de93a9b037f4a7
Submitter: Jenkins
Branch: stable/liberty

commit 3011dc0d130bfde9b5504bc507de93a9b037f4a7
Author: Kiall Mac Innes <email address hidden>
Date: Tue May 10 13:06:49 2016 +0100

Support both olso.m v4 and v5

    Oslo.Messaging v5 made some API changes which broke us in
    I5f23e23644e90919cb67f81fc306ee85c5e09974. Update our
    code to "detect" this API change, and behave accordingly.

    Closes-Bug: 1580139
    Partial-Bug: 1412977
    Change-Id: I5b44cd2ded32d90be6efda7b5238df72ce6c6cbd
    (cherry picked from commit ca7ffbab5b0df9cffa783a1864196c17cfd40b49)

tags:

added: in-stable-liberty

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-10: Fix merged to designate (stable/mitaka)

#10

Reviewed: https://review.openstack.org/314609
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=85b172c04781052bae05368f3e6ac512388bdec5
Submitter: Jenkins
Branch: stable/mitaka

commit 85b172c04781052bae05368f3e6ac512388bdec5
Author: Kiall Mac Innes <email address hidden>
Date: Tue May 10 13:06:49 2016 +0100

Support both olso.m v4 and v5

    Oslo.Messaging v5 made some API changes which broke us in
    I5f23e23644e90919cb67f81fc306ee85c5e09974. Update our
    code to "detect" this API change, and behave accordingly.

    Closes-Bug: 1580139
    Partial-Bug: 1412977
    Change-Id: I5b44cd2ded32d90be6efda7b5238df72ce6c6cbd
    (cherry picked from commit ca7ffbab5b0df9cffa783a1864196c17cfd40b49)

tags:

added: in-stable-mitaka

Revision history for this message

Kiall Mac Innes (kiall) wrote on 2016-05-10:

#11

Related: https://review.openstack.org/#/c/314732/ - will allow us to use the get_rpc_server helper method.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-11: Change abandoned on barbican (master)

#12

Change abandoned by Paulo Ewerton Gomes Fragoso (<email address hidden>) on branch: master
Review: https://review.openstack.org/315054
Reason: Ooops... it seems there's a better solution submitted here: https://review.openstack.org/#/c/314881/

Revision history for this message

Juan Antonio Osorio Robles (juan-osorio-robles) wrote on 2016-05-11:

#13

Barbican bug is closed by this commit https://review.openstack.org/#/c/314881/

Changed in barbican:
assignee:	nobody → Juan Antonio Osorio Robles (juan-osorio-robles)
status:	New → Fix Committed

Revision history for this message

Juan Antonio Osorio Robles (juan-osorio-robles) wrote on 2016-05-12:

#14

This was fixed by https://review.openstack.org/#/c/314881/

Changed in barbican:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Fix merged to mistral (master)

#15

Reviewed: https://review.openstack.org/316578
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=87aeb0ac5afb9765ed81fe48264f14f35ea9dedc
Submitter: Jenkins
Branch: master

commit 87aeb0ac5afb9765ed81fe48264f14f35ea9dedc
Author: Renat Akhmerov <email address hidden>
Date: Mon May 16 12:17:18 2016 +0700

Remove oslo.messaging hack since it's broken with 5.0.0 version

Change-Id: If25e96f0712dd2c9129101325c4cd23d3c9ca259
Closes-Bug: #1580139

Changed in mistral:
status:	New → Fix Released

Renat Akhmerov (rakhmerov) on 2016-05-17

Changed in mistral:
importance:	Undecided → Critical
assignee:	nobody → Renat Akhmerov (rakhmerov)
milestone:	none → newton-1

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-06-02: Fix included in openstack/mistral 3.0.0.0b1

#16

This issue was fixed in the openstack/mistral 3.0.0.0b1 development milestone.

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-06-02: Fix included in openstack/designate 3.0.0.0b1

#17

This issue was fixed in the openstack/designate 3.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-20: Fix proposed to mistral (stable/mitaka)

#18

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344771

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-21: Fix merged to mistral (stable/mitaka)

#19

Reviewed: https://review.openstack.org/344771
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=4317b3c1a8238e962501785b34dc08473a5563b4
Submitter: Jenkins
Branch: stable/mitaka

commit 4317b3c1a8238e962501785b34dc08473a5563b4
Author: Renat Akhmerov <email address hidden>
Date: Mon May 16 12:17:18 2016 +0700

Remove oslo.messaging hack since it's broken with 5.0.0 version

Change-Id: If25e96f0712dd2c9129101325c4cd23d3c9ca259
Closes-Bug: #1580139

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-22: Fix included in openstack/designate 2.1.0

#20

This issue was fixed in the openstack/designate 2.1.0 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.