terminate all sessions from other device does not work properly

Bug #1580050 reported by Roberto Mier Escandon
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Telegram app
Fix Released
Critical
Unassigned

Bug Description

Steps to reproduce:
- Start Ubuntu Touch telegram app in device A
- From computer web telegram, click in settings/terminate all sessions but current one

Expected
- session in device A is terminated and somehow the app should notify about it

Result
- app in device A behaves as the device has no connection but any visible sign of being logged out, though indeed the app is logged out, since if you see the log traces under .cache/upstart/<telegram-app-log-file> you can see AUTH_KEY_UNREGISTERED error in an infinite loop.

Something like http://paste.ubuntu.com/16341083/

Tags: cqa-verified

Related branches

Revision history for this message
Jin (jindallo) wrote :

I confirmed this bug,
after the Telegram app. killed by user and re-launch,
it shows a blank.

Besides, other device will get the authentication code over and over,
within the unstable state of device A.

Then I got this error in applog.sh as well:
    [20160511 16:09:16.644 CST qml: auth error: SESSION_REVOKED
    [20160511 16:09:16.644 CST error_slt 401 "SESSION_REVOKED" "accountUnregisterDevice

Changed in telegram-app:
status: New → Confirmed
Jin (jindallo)
Changed in telegram-app:
milestone: none → m31
Jin (jindallo)
Changed in telegram-app:
assignee: nobody → Paz Chauhan (paz-chauhan)
Revision history for this message
Jin (jindallo) wrote :

Hello Paz,

Please help us to look into this issue,
thanks!

Revision history for this message
Jin (jindallo) wrote :

After discussed with Ash,
I add the pass criteria here:
    1. Need to remove the account data completely
    - under .config folder
    - under .cache folder
    2. Need to refresh the main page (AccountPage) after data deleted
    - show IntroPage when the last account be removed from other device
    - show the previous account which is logged in successfully (multi-accounts)
    3. No need to show popup/dialog to users
    (Since the termination is made by user himself)
    (Android Telegram has no any warning dialog as well)

Ash (ashley-richards)
Changed in telegram-app:
status: Confirmed → In Progress
Revision history for this message
Jin (jindallo) wrote :

Bug fixed,
and verified pass on developer side.

The change list is submitted as rev. 205,
below is the detail information.
    http://bazaar.launchpad.net/~libqtelegram-team/telegram-app/telegram/revision/205

Device Information:
    current build number: 442
    device name: mako
    channel: ubuntu-touch/rc-proposed/ubuntu
    last update: 2016-05-19 19:28:28
    version version: 442
    version ubuntu: 20160518.1
    version device: 20160401.1
    version custom: 20160518.1

Changed in telegram-app:
status: In Progress → Fix Committed
Revision history for this message
Jin (jindallo) wrote :

Hello Elsa,

Please help us to QA this bug fix,
thanks.

Changed in telegram-app:
assignee: Paz Chauhan (paz-chauhan) → Elsa Wang (elsawang)
Elsa Wang (elsawang)
Changed in telegram-app:
assignee: Elsa Wang (elsawang) → Ethan Chang (ethan.chang)
Revision history for this message
Jin (jindallo) wrote :

Hello Ethan,

Please use attached click for do the validation,
thanks for your help!

Any problem in testing you could contact me directly.

Revision history for this message
Ethan Chang (ethan.chang) wrote :

I was verifying this issue with v2.2.23.0 , after terminated all other sessions then the telegram app shows blank page but not intro page. Please help to check again.

Changed in telegram-app:
assignee: Ethan Chang (ethan.chang) → Jin (jin.cth)
status: Fix Committed → Confirmed
Revision history for this message
Jin (jindallo) wrote :

I confirmed,
sometimes it shows a blank, not IntroPage,
but it can not be reproduced by 100%,
from my observation it is 50%.

I can see "SESSION_REVOKED" in log,
    error_slt 401 "SESSION_REVOKED" "messagesGetDialogs"
and it looks like the QML layer is in a wrong state.
(since there is no data in .config folder)

Revision history for this message
Ash (ashley-richards) wrote :

Hi @ethan,

Did you encounter the blank page with just one or multiple accounts on the device that gets terminated?

Also what device did you see this happening on? Because I have just branched latest from main trunk and ran this test again on Aquaris E4.5 - 15.04 (OTA-10.1) and I don't encounter a blank page but instead directs me straight to Intro Page (without multiple accounts) as expected.

Thanks.

Revision history for this message
Ethan Chang (ethan.chang) wrote :

Hi Ash,
1. It happens with just one account logged in
2. I was running on a M10(Frieza) tablet , I will try with phone later.

Revision history for this message
Ash (ashley-richards) wrote :

I manage to produce the blank screen:

1. Navigate to a conversation
2. Tap into group details (top right, person icon)
3. Terminate all sessions
4. Showed blank screen

I have just fixed this issue and will be pushing up the fix momentarily.
Thanks for making us aware of this issue.

Jin (jindallo)
Changed in telegram-app:
assignee: Jin (jin.cth) → Ash (ashley-richards)
Jin (jindallo)
Changed in telegram-app:
status: Confirmed → In Progress
Jin (jindallo)
Changed in telegram-app:
milestone: m31 → m32
Revision history for this message
Jin (jindallo) wrote :

Bug fixed,
and verified pass on developer side.

The change list is submitted as rev. 214,
below is the detail information.
    http://bazaar.launchpad.net/~libqtelegram-team/telegram-app/telegram/revision/214

Device Information:
    current build number: 475
    device name: mako
    channel: ubuntu-touch/rc-proposed/ubuntu
    last update: 2016-06-30 15:40:52
    version version: 475
    version ubuntu: 20160630
    version device: 20160401.1
    version custom: 20160630

Changed in telegram-app:
status: In Progress → Fix Committed
assignee: Ash (ashley-richards) → Jin (jin.cth)
Revision history for this message
Jin (jindallo) wrote :

Please use version 2.2.29.0 as current main trunk build to verify this issue,
many thanks.

Revision history for this message
Ethan Chang (ethan.chang) wrote :

Verified with ver 2.2.29.0.

tags: added: cqa-verified
Jin (jindallo)
Changed in telegram-app:
status: Fix Committed → Fix Released
assignee: Jin (jin.cth) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.