doesn't compile on 4.4.0-21-generic

[Bas Zoetekouw]

Teh broadcom-sta kernel module no longer compiles on kernel 4.4.0-21 (yaketty). Xenial kernel works fine.

-------- Uninstall Beginning --------
Module: broadcom-sta
Version: 6.30.223.271
Kernel: 4.4.0-21-generic (x86_64)
-------------------------------------

Status: Before uninstall, this module version was ACTIVE on this kernel.

wl.ko:
 - Uninstallation
   - Deleting from: /lib/modules/4.4.0-21-generic/updates/dkms/
 - Original module
   - No original module was found for this module on this kernel.
   - Use the dkms install command to reinstall any previous module version.

depmod.....

Backing up initrd.img-4.4.0-21-generic to /boot/initrd.img-4.4.0-21-generic.old-dkms
Making new initrd.img-4.4.0-21-generic
(If next boot fails, revert to initrd.img-4.4.0-21-generic.old-dkms image)
update-initramfs....

DKMS: uninstall completed.

------------------------------
Deleting module version: 6.30.223.271
completely from the DKMS tree.
------------------------------
Done.
Unpacking broadcom-sta-dkms (6.30.223.271-2) over (6.30.223.271-2) ...
Processing triggers for initramfs-tools (0.122ubuntu8) ...
update-initramfs: Generating /boot/initrd.img-4.4.0-22-generic
Setting up broadcom-sta-dkms (6.30.223.271-2) ...
Loading new broadcom-sta-6.30.223.271 DKMS files...
Building only for 4.4.0-22-generic
Building initial module for 4.4.0-22-generic
ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/broadcom-sta-dkms.0.crash'
Error! Bad return status for module build on kernel: 4.4.0-22-generic (x86_64)
Consult /var/lib/dkms/broadcom-sta/6.30.223.271/build/make.log for more information.

and the make.log shows:

DKMS make.log for broadcom-sta-6.30.223.271 for kernel 4.4.0-22-generic (x86_64)
ma 9 mei 2016 9:18:48 CEST
/bin/sh: 1: [: Illegal number:
/bin/sh: 1: [: Illegal number:
Wireless Extension is the only possible API for this kernel version
Using Wireless Extension API
KBUILD_NOPEDANTIC=1 make -C /lib/modules/4.4.0-22-generic/build M=`pwd`
make[1]: Entering directory '/usr/src/linux-headers-4.4.0-22-generic'
arch/x86/Makefile:133: stack-protector enabled but compiler support broken
Makefile:670: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
CFG80211 API is prefered for this kernel version
Using CFG80211 API
Kernel architecture is X86_64
  LD /var/lib/dkms/broadcom-sta/6.30.223.271/build/built-in.o
  CC [M] /var/lib/dkms/broadcom-sta/6.30.223.271/build/src/shared/linux_osl.o
/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/shared/linux_osl.c:1:0: error: code model kernel does not support PIC mode
 /*
 ^
scripts/Makefile.build:258: recipe for target '/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/shared/linux_osl.o' failed
make[2]: *** [/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/shared/linux_osl.o] Error 1
Makefile:1396: recipe for target '_module_/var/lib/dkms/broadcom-sta/6.30.223.271/build' failed
make[1]: *** [_module_/var/lib/dkms/broadcom-sta/6.30.223.271/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.4.0-22-generic'
Makefile:177: recipe for target 'all' failed
make: *** [all] Error 2

[Bas Zoetekouw (baszoetekouw)]

Seems to be related to this change in gcc-5:

gcc-5 (5.3.1-15ubuntu1) yakkety; urgency=medium

  * Turn on -fPIE and -z now by default on amd64 and ppc64el.

[Bas Zoetekouw (baszoetekouw)]

Confirmed: downgrading to gcc-5 5.3.1-14ubuntu2 from xenial fixes the issue, as does adding explicit -fno-PIE -fno-PIC to KBUILD_CFLAGS in the kernel headers Makefile.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Bas Zoetekouw (baszoetekouw)]

Note that this bug does not just affect the broadcom-sta package; it seems _all_ packages using dkms are affected.
The bug should probably be reassigned to dkms or to the kernel.

[Daniel van Vugt (vanvugt)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. This particular bug has already been reported and is a duplicate of bug 1578455, so it is being marked as such. Please look at the other bug report to see if there is any missing information that you can provide, or to see if there is a workaround for the bug. Additionally, any further discussion regarding the bug should occur in the other report. Feel free to continue to report any other bugs you may find.