[2.0b4] Can attempt to commission enlisted nodes without chosen power type
Bug #1579215 reported by
Newell Jensen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Medium
|
Newell Jensen |
Bug Description
After enlisting some VMs, I was able to select commissioning for them on the nodes list page as well as on the node detail page. This was allowed even though the power type and power parameters to power control the node where not entered and saved. This should not be allowed until the user selects a power type and the power parameters are saved so that MAAS knows how to power control the nodes.
Related branches
lp:~newell-jensen/maas/fix-1579215
- Mike Pontillo (community): Approve
-
Diff: 46 lines (+14/-0)3 files modifiedsrc/maasserver/api/tests/test_enlistment.py (+1/-0)
src/maasserver/models/node.py (+6/-0)
src/maasserver/models/tests/test_node.py (+7/-0)
summary: |
- [2.0b4] Can commission enlisted nodes without chosen power type + [2.0b4] Can attempt to commission enlisted nodes without chosen power + type |
Changed in maas: | |
assignee: | nobody → Newell Jensen (newell-jensen) |
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If no power parameter is selected, I'm thinking that we should either assume 'manual' power parameter by default and show a message that no pwoer parameter was chosen. Or it should always default to manual if not set.