Do not send default load balance attribute over xmpp

Bug #1579169 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Medium
Ananth Suryanarayana
Trunk
Fix Committed
Medium
Ananth Suryanarayana

Bug Description

Receiver (agent) already falls back to default if load-attribute is not sent. This attribute is long and verbose and not pleasant for eyes. Most of the time, it would point to the default 5-tuple set. Hence, no need to send it across the wire

It would have been nice if schema supported default values for the vector. Then receiver code would have been even simpler.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19966
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/19968
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19966
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/19968
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19966
Committed: http://github.org/Juniper/contrail-controller/commit/fc3ad27177659139f5f60f176e8dcf3074d3f466
Submitter: Zuul
Branch: master

commit fc3ad27177659139f5f60f176e8dcf3074d3f466
Author: Ananth Suryanarayana <email address hidden>
Date: Fri May 6 11:07:48 2016 -0700

Do not send default load balance attribute over xmpp

Receiver (agent) already falls back to default if load-attribute is not sent.
This attribute is long and verbose and not pleasant for eyes. Most of the time,
it would point to the default 5-tuple set. Hence, no need to send it across the
wire.

It would have been nice if schema supported default values for the vector.
Then receiver code would have been even simpler. But it is not the case at the
moment.

Change-Id: Ia5a18f5896e40f1aaee4238b57be538620a529c1
Closes-Bug: 1579169

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19968
Committed: http://github.org/Juniper/contrail-controller/commit/dc50487d1d7bbce1c2901719fa58f458c9aa65aa
Submitter: Zuul
Branch: R3.0

commit dc50487d1d7bbce1c2901719fa58f458c9aa65aa
Author: Ananth Suryanarayana <email address hidden>
Date: Fri May 6 11:07:48 2016 -0700

Do not send default load balance attribute over xmpp

Receiver (agent) already falls back to default if load-attribute is not sent.
This attribute is long and verbose and not pleasant for eyes. Most of the time,
it would point to the default 5-tuple set. Hence, no need to send it across the
wire.

It would have been nice if schema supported default values for the vector.
Then receiver code would have been even simpler. But it is not the case at the
moment.

Change-Id: Ia5a18f5896e40f1aaee4238b57be538620a529c1
Closes-Bug: 1579169

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.