Send Location field to ILS driver at Login

Bug #1579144 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SIPServer
Fix Released
Wishlist
Unassigned

Bug Description

Field CP (Location) of the login message (93) is a user-defined string that is currently not passed along to the ILS driver. Sending it to the ILS would make it possible to determine which self check is responsible for a circ and so on. In the case of Evergreen it can be used as a Workstation name, I would assume Koha (or other ILS's) can make use of this field in their own way.

Tags: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :
tags: added: pullrequest
Jason Boyer (jboyer)
Changed in sipserver:
importance: Undecided → Wishlist
Revision history for this message
Jeff Godin (jgodin) wrote :

Jason-

I've recently pushed the changes in bug 1180468 to master, which completes a change of license for SIPServer first undertaken in 2011.

As someone with a working branch in existence before the license changes were pushed to master, could you please indicate your consent to the license change here in a comment, either as the individual holder of the copyright on your working branch, or on behalf of the copyright holder?

Thanks!

-jeff

Revision history for this message
Jason Boyer (jboyer) wrote :

Neither I nor my employer have any objection to the license change. Change-away!

Jason

Revision history for this message
Mike Rylander (mrylander) wrote :

I've added a one-line change to support server-configured workstations for clients that can't send a location code, as suggested by Bill over in bug 1259196. I'd like to include this with Jason's work in support of 2.11. Thoughts?

http://git.evergreen-ils.org/?p=working/SIPServer.git;a=shortlog;h=refs/heads/user/miker/lp1579144_login_location

Revision history for this message
Mike Rylander (mrylander) wrote :

I've picked in Jason's change, but left mine out. Any feedback on whether that would be useful would be appreciate. Thanks, Jason!

Revision history for this message
Blake GH (bmagic) wrote :

Signed off here
http://git.evergreen-ils.org/?p=working/SIPServer.git;a=shortlog;h=refs/heads/user/blake/lp1579144_login_location

(there was a merge conflict with master over some white space.

Revision history for this message
Mike Rylander (mrylander) wrote :

There was something off-kilter with that branch, so I'm just treating the comment here as sign-off and committing to master. Thanks very much for testing, Blake!

Changed in sipserver:
status: New → Fix Committed
Changed in sipserver:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.