libmysqlclient-dev compilation error -- wrong header definition at client_plugin.h

[Francis Brosnan]

The following file has a bug inside the header definition that causes gcc (4.9 and 5.3.1) to fail:

>> dpkg -S /usr/include/mysql/mysql/client_plugin.h
libmysqlclient-dev: /usr/include/mysql/mysql/client_plugin.h

The fix introduced is the following:

>> diff -u /usr/include/mysql/mysql/client_plugin.{h~,h}
--- /usr/include/mysql/mysql/client_plugin.h~ 2016-03-28 20:06:12.000000000 +0200
+++ /usr/include/mysql/mysql/client_plugin.h 2016-05-06 12:37:19.133420684 +0200
@@ -89,7 +89,7 @@
   const char *license; \
   void *mysql_api; \
   int (*init)(char *, size_t, int, va_list); \
- int (*deinit)(); \
+ int (*deinit)(void); \
   int (*options)(const char *option, const void *);

The fix resolves the following concrete compilation error:

/usr/include/mysql/mysql/client_plugin.h:97:3: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
   MYSQL_CLIENT_PLUGIN_HEADER
   ^
In file included from /usr/include/mysql/mysql.h:64:0,
                 from mod_sasl_mysql.c:5:
/usr/include/mysql/mysql/client_plugin.h:107:3: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
   MYSQL_CLIENT_PLUGIN_HEADER

[Francis Brosnan (francis-aspl)]

Bug discovered while building packages for Ubuntu 16.04 Xerus for Turbulence

[Robie Basak (racb)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Norvald, this sounds like your department. Please could you take a look?

[Lars Tangvald (lars-tangvald)]

Confirmed. There's an upstream bug for this (not currently fixed in 5.7): https://bugs.mysql.com/bug.php?id=78177

[Lars Tangvald (lars-tangvald)]

This impacts users as a regression because mysql.h now includes client_plugin.h, which it didn't in 5.6

[Norvald H. Ryeng (nryeng)]

This will be fixed in a future version of MySQL. Please see the attached patch.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Upstream patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Norvald H. Ryeng (nryeng)]

This bug is fixed in MySQL 5.7.14.

[Robie Basak (racb)]

5.7.15 is in Debian VCS, Xenial and in Yakkety's proposed pocket, so marking this as Fix Committed. We can mark it Fix Released as soon as 5.7.15 lands in Yakkety's release pocket.

[Lars Tangvald (lars-tangvald)]

5.7.15 has landed in Yakkety now :)