Inkscape

cmake hardcodes /usr/lib/inkscape as plugin directory

Bug #1578164 reported by Fabio Valentini
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
YuGiOhJCJ
Inkscape 1.0
0.92.x
Triaged
Medium
Unassigned
Inkscape 0.92.5 "0.92.5"

Bug Description

cmake hardcodes PREFIX/lib/inkscape as plugin directory.

see
src/CMakeLists.txt:574,575

this should use CMAKE_INSTALL_LIBDIR [1] -
many distros don't like arch-specific stuff in /usr/lib (e.g. on x86_64) and set that variable in package builds according to guidelines (e.g. fedora).

[1] https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html?highlight=libdir

Related branches

lp:~yugiohjcj/inkscape/yugiohjcj-inkscape
Bryce Harrington (community): Approve (code)
Diff: 68 lines (+9/-7)
3 files modified
CMakeLists.txt (+5/-3)
CMakeScripts/HelperMacros.cmake (+2/-2)
src/CMakeLists.txt (+2/-2)
Alex Valavanis (valavanisalex)
tags: added: cmake
tags: added: build
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.92
jazzynico (jazzynico)
Changed in inkscape:
milestone: 0.92 → 0.93
Revision history for this message
Bryce Harrington (bryce) wrote :

Ack'd for the 0.92.x branch once it's been landed on trunk & tested.

Changed in inkscape:
assignee: nobody → YuGiOhJCJ (yugiohjcj)
status: New → In Progress
Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

This still needs to be forwarded to master (and possibly 0.92.x).

Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

@YuGiOhJCJ: hey there, can you submit this as a merge request on GitLab? If you don't want to I can do that for you.

Revision history for this message
YuGiOhJCJ (yugiohjcj) wrote :

Indeed meanwhile Inkscape has moved to GitLab.
I have a technical problem to register to GitLab: I do not receive the confirmation mail.
I am working on this problem.
As soon as it is fixed, I will try to do it.

Revision history for this message
YuGiOhJCJ (yugiohjcj) wrote :

OK, I fixed my technical problem to register to GitLab.
Also, I submitted a merge request on GitLab: https://gitlab.com/inkscape/inkscape/merge_requests/633

Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

Fix committed to master here: https://gitlab.com/inkscape/inkscape/commit/746904b607dc466096d6d9e628e0b6ffd10d81e8

Closed by: https://gitlab.com/Qantas94Heavy

Changed in inkscape:
status: In Progress → Fix Committed
tbnorth (terry-n-brown)
tags: added: bug-migration
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.